Clay Daniels has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/49112 )
Change subject: Add Nuvoton NCT6797D to coreboot/util/superiotool/nuvoton.c ......................................................................
Add Nuvoton NCT6797D to coreboot/util/superiotool/nuvoton.c
+ {0xD451, "NCT6797D" same as {0xc803, "NCT6791D" UART
Signed-off-by: Clay clay.daniels.jr@gmail.com Change-Id: I1a5f962f2fd9dc479ddbbaf5e1bebea2c7c9e03f --- M util/superiotool/nuvoton.c 1 file changed, 50 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/49112/1
diff --git a/util/superiotool/nuvoton.c b/util/superiotool/nuvoton.c index d2b72f2..6e43115 100644 --- a/util/superiotool/nuvoton.c +++ b/util/superiotool/nuvoton.c @@ -567,6 +567,56 @@ {0x30,0xe0,0xe1,0xe2,0xe3,EOT}, {0x20,0x20,0x04,0x05,0x01,EOT}}, {EOT}}}, + {0xd451, "NCT6797D", { + {NOLDN, NULL, + {0x07,0x10,0x11,0x13,0x14,0x1a,0x1b,0x1c,0x1d,0x20,0x21,0x22,0x24,0x25,0x26,0x27,0x28,0x2a,0x2b,0x2c,0x2d,0x2f,EOT}, + {0x00,0xff,0xff,0x00,0x00,0x30,0x70,0x10,0x00,0xc8,0x03,0xff,0x04,0x00,MISC,0x00,0x00,0xc0,0x00,0x01,0x00,MISC,EOT}}, + {0x01, "Parallel Port", + {0x30,0x60,0x61,0x70,0x74,0xf0,EOT}, + {0x01,0x03,0x78,0x07,0x04,0x3f,EOT}}, + {0x02, "UART A", + {0x30,0x60,0x61,0x70,0xf0,0xf2,EOT}, + {0x01,0x03,0xf8,0x04,0x00,0x00,EOT}}, + {0x03, "UART B, IR", + {0x30,0x60,0x61,0x70,0xf0,0xf1,0xf2,EOT}, + {0x01,0x02,0xf8,0x03,0x00,0x00,0x00,EOT}}, + {0x05, "Keyboard Controller", + {0x30,0x60,0x61,0x62,0x63,0x70,0x72,0xf0,EOT}, + {0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x83,EOT}}, + {0x06, "Consumer IR", + {0x30,0x60,0x61,0x70,0xf0,0xf1,0xf2,0xf3,EOT}, + {0x00,0x00,0x00,0x00,0x08,0x09,0x32,0x00,EOT}}, + {0x07, "GPIO 6, GPIO 7, GPIO 8", + {0x30,0xe0,0xe1,0xe2,0xe3,0xe4,0xe5,0xe6,0xe7,0xec,0xed,0xf4,0xf5,0xf6,0xf7,0xf8,EOT}, + {0x00,0x7f,0x00,0x00,0x00,0xff,0x00,0x00,0x00,0x00,0x00,0xff,0x00,0x00,0x00,0x00,EOT}}, + {0x08, "WDT1, WDT_MEM, GPIO 0, GPIO 1", + {0x30,0x60,0x61,0xe0,0xe1,0xe2,0xe3,0xe4,0xf0,0xf1,0xf2,0xf3,0xf4,0xf5,0xf6,0xf7,0xf8,0xf9,0xfa,0xfe,0xff,EOT}, + {0x00,0x00,0x00,0xff,0x00,0x00,0x00,0x00,0xff,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,EOT}}, + {0x09, "GPIO 2, GPIO 3, GPIO 4, GPIO 5", + {0x30,0xe0,0xe1,0xe2,0xe3,0xe4,0xe5,0xe6,0xe7,0xe8,0xe9,0xea,0xeb,0xee,0xf0,0xf1,0xf2,0xf4,0xf5,0xf6,0xf7,0xfe,EOT}, + {0x00,0xff,0x00,0x00,0x00,0x7f,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0xff,0x00,0x00,0xff,0x00,0x00,0x00,0x00,EOT}}, + {0x0a, "ACPI", + {0xe0,0xe1,0xe2,0xe3,0xe4,0xe5,0xe6,0xe7,0xe9,0xec,0xed,0xee,0xf0,0xf2,0xf3,0xf4,0xf6,0xf7,0xfc,0xfe,EOT}, + {0x01,0x00,0x00,0x00,0x00,0x02,0x1a,0x00,0x00,0x00,0x00,0x00,0x10,0x5c,0x00,0x00,0x00,0xc0,0x00,0x00,EOT}}, + {0x0b, "Hardware Monitor, Front Panel LED", + {0x30,0x60,0x61,0x62,0x63,0x70,0xe0,0xe1,0xe2,0xe3,0xe4,0xe6,0xe7,0xf0,0xf1,0xf2,0xf5,0xf6,0xf7,0xf8,0xf9,0xfa,0xfb,EOT}, + {0x00,0x00,0x00,0x00,0x00,0x00,0x7f,0x7f,0xff,0xff,0xff,0x08,0xff,0x00,0x00,0x00,0x10,0x00,0x87,0x47,0x00,0x00,0x00,EOT}}, + {0x0d, "BCLK, WDT2, WDT_MEM", + {0xe0,0xe1,0xe7,0xe8,0xeb,0xed,0xf0,0xf3,EOT}, + {0x00,MISC,0x00,0x32,0x14,0x00,0x00,0x00,EOT}}, + {0x0e, "CIR Wake-Up", + {0x30,0x60,0x61,0x70,EOT}, + {0x00,0x00,0x00,0x00,EOT}}, + {0x0f, "GPIO Push-Pull or Open-Drain selection", + {0xe0,0xe1,0xe2,0xe3,0xe4,0xe5,0xe6,0xe7,0xe9,0xf0,0xf1,0xf2,EOT}, + {0xff,0xff,0x7f,0xff,0xff,0xff,0x0f,0xff,0xff,0x9d,0x00,0x00,EOT}}, + {0x14, "Port 80 UART", + {0xe0,0xe1,0xe2,0xe3,0xe4,EOT}, + {0x80,0x00,0x00,0x10,0x00,EOT}}, + {0x16, "Deep Sleep", + {0x30,0xe0,0xe1,0xe2,0xe3,EOT}, + {0x20,0x20,0x04,0x05,0x01,EOT}}, + {EOT}}}, {0xd121, "NCT5539D", { {NOLDN, NULL, {0x10,0x11,0x13,0x14,0x1a,0x1b,0x1c,0x1d,0x22,0x24,
Hello build bot (Jenkins), Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/49112
to look at the new patch set (#2).
Change subject: Add Nuvoton NCT6797D to coreboot/util/superiotool/nuvoton.c ......................................................................
Add Nuvoton NCT6797D to coreboot/util/superiotool/nuvoton.c
+ {0xD451, "NCT6797D" same as {0xc803, "NCT6791D" UART
Signed-off-by: Clay clay.daniels.jr@gmail.com Change-Id: I1a5f962f2fd9dc479ddbbaf5e1bebea2c7c9e03f
Test Output: root@clay-MS-7C37:/home/clay/coreboot/util/superiotool# superiotool superiotool r4.13-823-g1b07fd85e9 Found Nuvoton NCT6797D (id=0xd451) at 0x4e root@clay-MS-7C37:/home/clay/coreboot/util/superiotool#
Change-Id: I1a5f962f2fd9dc479ddbbaf5e1bebea2c7c9e03f --- M util/superiotool/nuvoton.c 1 file changed, 50 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/49112/2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49112 )
Change subject: Add Nuvoton NCT6797D to coreboot/util/superiotool/nuvoton.c ......................................................................
Patch Set 2:
(4 comments)
Welcome to coreboot, and thank you for the patch.
https://review.coreboot.org/c/coreboot/+/49112/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/49112/2//COMMIT_MSG@7 PS2, Line 7: Add Nuvoton NCT6797D to coreboot/util/superiotool/nuvoton.c Please use the prefix:
superiotool: Add ID for Nuvoton NCT6797D
https://review.coreboot.org/c/coreboot/+/49112/2//COMMIT_MSG@9 PS2, Line 9: + {0xD451, "NCT6797D" same as {0xc803, "NCT6791D" UART This is in the code, but maybe document, what datasheet you used.
https://review.coreboot.org/c/coreboot/+/49112/2//COMMIT_MSG@12 PS2, Line 12: Change-Id: I1a5f962f2fd9dc479ddbbaf5e1bebea2c7c9e03f Please move this block to the end, and only use Change-Id once.
https://review.coreboot.org/c/coreboot/+/49112/2//COMMIT_MSG@18 PS2, Line 18: root@clay-MS-7C37:/home/clay/coreboot/util/superiotool# This line can be removed.
Hello build bot (Jenkins), Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/49112
to look at the new patch set (#3).
Change subject: superiotool: Add ID for Nuvoton NCT6797D ......................................................................
superiotool: Add ID for Nuvoton NCT6797D
Similar to: https://www.nuvoton.com/products/cloud-computing/i-o/super-i-o-series/nct679...
Signed-off-by: Clay clay.daniels.jr@gmail.com
Test Output: root@clay-MS-7C37:/home/clay/coreboot/util/superiotool# superiotool superiotool r4.13-823-g1b07fd85e9 Found Nuvoton NCT6797D (id=0xd451) at 0x4e
Change-Id: I1a5f962f2fd9dc479ddbbaf5e1bebea2c7c9e03f --- M util/superiotool/nuvoton.c 1 file changed, 50 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/49112/3
Clay Daniels has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49112 )
Change subject: superiotool: Add ID for Nuvoton NCT6797D ......................................................................
Patch Set 3:
Patch Set 2:
(4 comments)
Welcome to coreboot, and thank you for the patch.
Thanks for the help! This is my first commit. I think I made the changes you suggested, and they make good sense. I did not find the datasheet for the NCT6797D but based it on the NTC6791D which is similar. It works for me when I tested it on my computer. Let me know what more I need to do.
Clay Daniels has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49112 )
Change subject: superiotool: Add ID for Nuvoton NCT6797D ......................................................................
Patch Set 3:
Nico, remember helping me with my Nuvoton superio chip & the coreboot superiotool? I have made a commit to Gerrit #49112 and would appreciate a review from you.
Thanks, Clay (Boot_Dawg on irc)
Hello build bot (Jenkins), Nico Huber, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/49112
to look at the new patch set (#4).
Change subject: superiotool: Add ID for Nuvoton NCT6797D ......................................................................
superiotool: Add ID for Nuvoton NCT6797D
Similar to: https://www.nuvoton.com/products/cloud-computing/i-o/super-i-o-series/nct679...
Test Output: root@clay-MS-7C37:/home/clay/coreboot/util/superiotool# superiotool superiotool r4.13-823-g1b07fd85e9 Found Nuvoton NCT6797D (id=0xd451) at 0x4e
Change-Id: I1a5f962f2fd9dc479ddbbaf5e1bebea2c7c9e03f Signed-off-by: Clay clay.daniels.jr@gmail.com --- M util/superiotool/nuvoton.c 1 file changed, 50 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/49112/4
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49112 )
Change subject: superiotool: Add ID for Nuvoton NCT6797D ......................................................................
Patch Set 4:
(2 comments)
only had a very brief look and didn't verify any of the registers and values
https://review.coreboot.org/c/coreboot/+/49112/4/util/superiotool/nuvoton.c File util/superiotool/nuvoton.c:
https://review.coreboot.org/c/coreboot/+/49112/4/util/superiotool/nuvoton.c@... PS4, Line 571: the indentations here should be tabs to be consistent with the existing code
https://review.coreboot.org/c/coreboot/+/49112/4/util/superiotool/nuvoton.c@... PS4, Line 597: {0x00,0xff,0x00,0x00,0x00,0x7f,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0xff,0x00,0x00,0xff,0x00,0x00,0x00,0x00,EOT}}, i'd expect some of the registers to be the gpio input registers. if you know which ones those are, it would be good to mark them as NANA like it's done for NCT5539D below; if not, just keep it the way it is now and mark this one as resolved. same for the other GPIO LDNs
Clay Daniels has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49112 )
Change subject: superiotool: Add ID for Nuvoton NCT6797D ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/49112/4/util/superiotool/nuvoton.c File util/superiotool/nuvoton.c:
https://review.coreboot.org/c/coreboot/+/49112/4/util/superiotool/nuvoton.c@... PS4, Line 571:
the indentations here should be tabs to be consistent with the existing code
You were right, I didn't see all the single spaces instead of tabs. Fixed.
https://review.coreboot.org/c/coreboot/+/49112/4/util/superiotool/nuvoton.c@... PS4, Line 597: {0x00,0xff,0x00,0x00,0x00,0x7f,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0xff,0x00,0x00,0xff,0x00,0x00,0x00,0x00,EOT}},
i'd expect some of the registers to be the gpio input registers. […]
I modeled NCT6797D on the NTC6791D directly above, and there are no NANA entries. I will leave it for now, pending any new information.
Hello build bot (Jenkins), Nico Huber, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/49112
to look at the new patch set (#5).
Change subject: Add Nuvoton NCT6797D to coreboot/util/superiotool/nuvoton.c ......................................................................
Add Nuvoton NCT6797D to coreboot/util/superiotool/nuvoton.c
+ {0xD451, "NCT6797D" same as {0xc803, "NCT6791D" UART
Signed-off-by: Clay clay.daniels.jr@gmail.com Change-Id: I1a5f962f2fd9dc479ddbbaf5e1bebea2c7c9e03f --- M util/superiotool/nuvoton.c 1 file changed, 50 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/49112/5
Hello build bot (Jenkins), Nico Huber, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/49112
to look at the new patch set (#6).
Change subject: Add Nuvoton NCT6797D to coreboot/util/superiotool/nuvoton.c ......................................................................
Add Nuvoton NCT6797D to coreboot/util/superiotool/nuvoton.c
+ {0xD451, "NCT6797D" same as {0xc803, "NCT6791D" UART
Signed-off-by: Clay clay.daniels.jr@gmail.com Change-Id: I1a5f962f2fd9dc479ddbbaf5e1bebea2c7c9e03f --- M util/superiotool/nuvoton.c 1 file changed, 50 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/49112/6
Attention is currently required from: Felix Held. Clay Daniels has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49112 )
Change subject: Add Nuvoton NCT6797D to coreboot/util/superiotool/nuvoton.c ......................................................................
Patch Set 6:
(1 comment)
File util/superiotool/nuvoton.c:
https://review.coreboot.org/c/coreboot/+/49112/comment/c7675297_67f98753 PS4, Line 571:
You were right, I didn't see all the single spaces instead of tabs. Fixed.
Fixed lines 572 to 619 to change indents from single spacing to tabs. I was a bit slow to realize what you pointed to in line 571 needed to be done for the rest. Sorry for being a slow dummy. ;-|
Attention is currently required from: Paul Menzel, Felix Held. Clay Daniels has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49112 )
Change subject: Add Nuvoton NCT6797D to coreboot/util/superiotool/nuvoton.c ......................................................................
Patch Set 6:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/49112/comment/61d54031_dcd2db76 PS2, Line 7: Add Nuvoton NCT6797D to coreboot/util/superiotool/nuvoton.c
Please use the prefix: […]
Ack
https://review.coreboot.org/c/coreboot/+/49112/comment/52830de5_f79355bd PS2, Line 9: + {0xD451, "NCT6797D" same as {0xc803, "NCT6791D" UART
This is in the code, but maybe document, what datasheet you used.
Ack
https://review.coreboot.org/c/coreboot/+/49112/comment/98a7e823_c9848935 PS2, Line 12: Change-Id: I1a5f962f2fd9dc479ddbbaf5e1bebea2c7c9e03f
Please move this block to the end, and only use Change-Id once.
Ack
https://review.coreboot.org/c/coreboot/+/49112/comment/9bd1863a_f8c1fe59 PS2, Line 18: root@clay-MS-7C37:/home/clay/coreboot/util/superiotool#
This line can be removed.
Ack
Paul, I thought these four points were already acknowledged and fixed, but I guess it was only a draft. Sorry. Let me know if I need to make any other changes.
Patchset:
PS6: I thought I had these taken care of but I didn't sent the reply as it was still a draft. Sorry. Let me know if there is anything else I need to do.
Attention is currently required from: Paul Menzel, Felix Held. Hello build bot (Jenkins), Nico Huber, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/49112
to look at the new patch set (#8).
Change subject: superiotool: Add ID for Nuvoton NCT6797D ......................................................................
superiotool: Add ID for Nuvoton NCT6797D
Test Result: clay@clay-MS-7C37:~$ sudo superiotool [sudo] password for clay: superiotool r4.13-823-g221351f81b Found Nuvoton NCT6797D (id=0xd451) at 0x4e
Change-Id: I1a5f962f2fd9dc479ddbbaf5e1bebea2c7c9e03f Signed-off-by: Clay clay.daniels.jr@gmail.com --- M util/superiotool/nuvoton.c 1 file changed, 50 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/49112/8
Attention is currently required from: Paul Menzel, Clay Daniels, Felix Held. Hello build bot (Jenkins), Nico Huber, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/49112
to look at the new patch set (#9).
Change subject: superiotool: Add ID for Nuvoton NCT6797D ......................................................................
superiotool: Add ID for Nuvoton NCT6797D
Test Result: clay@clay-MS-7C37:~$ sudo superiotool [sudo] password for clay: superiotool r4.13-823-g221351f81b Found Nuvoton NCT6797D (id=0xd451) at 0x4e
Change-Id: I1a5f962f2fd9dc479ddbbaf5e1bebea2c7c9e03f Signed-off-by: Clay clay.daniels.jr@gmail.com --- M util/superiotool/nuvoton.c 1 file changed, 50 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/49112/9
Attention is currently required from: Paul Menzel, Felix Held. Clay Daniels has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49112 )
Change subject: superiotool: Add ID for Nuvoton NCT6797D ......................................................................
Patch Set 9:
(1 comment)
Patchset:
PS9: Felix & Paul, I think I have finally set up the changes you requested and invite you, and Nico too, to take a look.
Thanks for all your help, Clay Daniels
Attention is currently required from: Paul Menzel, Clay Daniels, Felix Held. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49112 )
Change subject: superiotool: Add ID for Nuvoton NCT6797D ......................................................................
Patch Set 9:
(1 comment)
File util/superiotool/nuvoton.c:
https://review.coreboot.org/c/coreboot/+/49112/comment/591b74e7_2132d6d1 PS4, Line 597: {0x00,0xff,0x00,0x00,0x00,0x7f,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0xff,0x00,0x00,0xff,0x00,0x00,0x00,0x00,EOT}},
I modeled NCT6797D on the NTC6791D directly above, and there are no NANA entries. […]
Hi, do you have the datasheet, though? If so, it would be nice to figure out for which registers a default makes sense, and which should have a NANA. We can guide you through that if you have the datasheet.
I happen to have the NCT6791D datasheet, so I'm going to write a patch for that right now.
Attention is currently required from: Nico Huber, Paul Menzel, Felix Held. Clay Daniels has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49112 )
Change subject: superiotool: Add ID for Nuvoton NCT6797D ......................................................................
Patch Set 9:
(2 comments)
Patchset:
PS9: Nico, the only datasheet I had was for the NCT6791D. I see you seem to have written line 541 to show the NANA entries. What do I need to do next?
File util/superiotool/nuvoton.c:
https://review.coreboot.org/c/coreboot/+/49112/comment/f8a6134f_7bc61e66 PS4, Line 597: {0x00,0xff,0x00,0x00,0x00,0x7f,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0xff,0x00,0x00,0xff,0x00,0x00,0x00,0x00,EOT}},
Hi, do you have the datasheet, though? If so, it would be nice to figure out […]
Nico, the only datasheet I had was for the NCT6791D. I see you seem to have written line 541 to show the NANA entries. What do I need to do next?
Attention is currently required from: Nico Huber, Paul Menzel, Felix Held. Hello build bot (Jenkins), Nico Huber, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/49112
to look at the new patch set (#10).
Change subject: superiotool: Add ID for Nuvoton NCT6797D ......................................................................
superiotool: Add ID for Nuvoton NCT6797D
Test Result: clay@clay-MS-7C37:~$ sudo superiotool [sudo] password for clay: superiotool r4.13-823-g221351f81b Found Nuvoton NCT6797D (id=0xd451) at 0x4e
Change-Id: I1a5f962f2fd9dc479ddbbaf5e1bebea2c7c9e03f Signed-off-by: Clay clay.daniels.jr@gmail.com --- M util/superiotool/nuvoton.c 1 file changed, 50 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/49112/10
Attention is currently required from: Paul Menzel, Clay Daniels, Felix Held. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49112 )
Change subject: superiotool: Add ID for Nuvoton NCT6797D ......................................................................
Patch Set 10: Code-Review+1
(2 comments)
Patchset:
PS10: Your superiotool dump [1] looks very reasonable. Please update the NANA fields as done in CB:49241 and adapt the printed name to make people aware of the unfortunate lack of a datasheet. I see no reason not to merge it then.
[1] https://paste.flashrom.org/view.php?id=3423
File util/superiotool/nuvoton.c:
https://review.coreboot.org/c/coreboot/+/49112/comment/e54ac78a_cf89728d PS10, Line 570: NCT6797D As we can never be 100% without a datasheet, how about naming this like
NCT6797D (experimental)
or
NCT6797D (potential subset)
or something like that.
Attention is currently required from: Nico Huber, Paul Menzel, Felix Held. Clay Daniels has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49112 )
Change subject: superiotool: Add ID for Nuvoton NCT6797D ......................................................................
Patch Set 10:
(3 comments)
Patchset:
PS10:
Your superiotool dump [1] looks very reasonable. Please update […]
Thanks. I just copied your NANA entries from NTC6791D.
PS10: Nico, thanks for all the help. I think I have this set up right now, but the mechanics of Gerrit are new to me.
File util/superiotool/nuvoton.c:
https://review.coreboot.org/c/coreboot/+/49112/comment/b7b3ff9d_57342912 PS10, Line 570: NCT6797D
As we can never be 100% without a datasheet, how about naming this like […]
Done: you are right, without a datasheet, we are doing educated guessing.
Attention is currently required from: Nico Huber, Paul Menzel, Felix Held. Hello build bot (Jenkins), Nico Huber, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/49112
to look at the new patch set (#11).
Change subject: superiotool: Add ID for Nuvoton NCT6797D ......................................................................
superiotool: Add ID for Nuvoton NCT6797D
Test Result: clay@clay-MS-7C37:~$ sudo superiotool [sudo] password for clay: superiotool r4.13-823-g221351f81b Found Nuvoton NCT6797D (id=0xd451) at 0x4e
Change-Id: I1a5f962f2fd9dc479ddbbaf5e1bebea2c7c9e03f Signed-off-by: Clay clay.daniels.jr@gmail.com --- M util/superiotool/nuvoton.c 1 file changed, 50 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/49112/11
Attention is currently required from: Paul Menzel, Clay Daniels, Felix Held. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49112 )
Change subject: superiotool: Add ID for Nuvoton NCT6797D ......................................................................
Patch Set 11: Code-Review+2
Attention is currently required from: Paul Menzel, Clay Daniels, Felix Held. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49112 )
Change subject: superiotool: Add ID for Nuvoton NCT6797D ......................................................................
Patch Set 11: Code-Review+2
Attention is currently required from: Paul Menzel, Clay Daniels, Felix Held. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49112 )
Change subject: superiotool: Add ID for Nuvoton NCT6797D ......................................................................
Patch Set 11:
(1 comment)
File util/superiotool/nuvoton.c:
https://review.coreboot.org/c/coreboot/+/49112/comment/74295b51_629bb1ec PS11, Line 570: (experimental) Hm?
Attention is currently required from: Paul Menzel, Clay Daniels, Felix Held. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49112 )
Change subject: superiotool: Add ID for Nuvoton NCT6797D ......................................................................
Patch Set 11:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/49112/comment/673f3a62_29969035 PS11, Line 13: (experimental)
File util/superiotool/nuvoton.c:
https://review.coreboot.org/c/coreboot/+/49112/comment/dec11c6c_f00a80c8 PS11, Line 570: (experimental)
Hm?
Ack
Attention is currently required from: Paul Menzel, Felix Held. Clay Daniels has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49112 )
Change subject: superiotool: Add ID for Nuvoton NCT6797D ......................................................................
Patch Set 11:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/49112/comment/383764d3_0ea51d7a PS11, Line 13:
(experimental)
This was per Nico's comments on Jan 24th
Patchset:
PS11: I hope this fixes it. Thanks for all the help, Angel & Nico.
File util/superiotool/nuvoton.c:
https://review.coreboot.org/c/coreboot/+/49112/comment/a7bd26d8_b1afe064 PS11, Line 570: (experimental)
Ack
Thanks, Angel! Someone needs to keep me straight.
Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/49112 )
Change subject: superiotool: Add ID for Nuvoton NCT6797D ......................................................................
superiotool: Add ID for Nuvoton NCT6797D
Test Result: clay@clay-MS-7C37:~$ sudo superiotool [sudo] password for clay: superiotool r4.13-823-g221351f81b Found Nuvoton NCT6797D (id=0xd451) at 0x4e
Change-Id: I1a5f962f2fd9dc479ddbbaf5e1bebea2c7c9e03f Signed-off-by: Clay clay.daniels.jr@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/49112 Reviewed-by: Nico Huber nico.h@gmx.de Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M util/superiotool/nuvoton.c 1 file changed, 50 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/util/superiotool/nuvoton.c b/util/superiotool/nuvoton.c index ffd12be..dfcbaf7 100644 --- a/util/superiotool/nuvoton.c +++ b/util/superiotool/nuvoton.c @@ -567,6 +567,56 @@ {0x30,0xe0,0xe1,0xe2,0xe3,EOT}, {0x20,0x20,0x04,0x05,0x01,EOT}}, {EOT}}}, + {0xd451, "NCT6797D (experimental)", { + {NOLDN, NULL, + {0x07,0x10,0x11,0x13,0x14,0x1a,0x1b,0x1c,0x1d,0x20,0x21,0x22,0x24,0x25,0x26,0x27,0x28,0x2a,0x2b,0x2c,0x2d,0x2f,EOT}, + {0x00,0xff,0xff,0x00,0x00,0x30,0x70,0x10,0x00,0xc8,0x03,0xff,0x04,0x00,MISC,0x00,0x00,0xc0,0x00,0x01,0x00,MISC,EOT}}, + {0x01, "Parallel Port", + {0x30,0x60,0x61,0x70,0x74,0xf0,EOT}, + {0x01,0x03,0x78,0x07,0x04,0x3f,EOT}}, + {0x02, "UART A", + {0x30,0x60,0x61,0x70,0xf0,0xf2,EOT}, + {0x01,0x03,0xf8,0x04,0x00,0x00,EOT}}, + {0x03, "UART B, IR", + {0x30,0x60,0x61,0x70,0xf0,0xf1,0xf2,EOT}, + {0x01,0x02,0xf8,0x03,0x00,0x00,0x00,EOT}}, + {0x05, "Keyboard Controller", + {0x30,0x60,0x61,0x62,0x63,0x70,0x72,0xf0,EOT}, + {0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x83,EOT}}, + {0x06, "Consumer IR", + {0x30,0x60,0x61,0x70,0xf0,0xf1,0xf2,0xf3,EOT}, + {0x00,0x00,0x00,0x00,0x08,0x09,0x32,0x00,EOT}}, + {0x07, "GPIO 6, GPIO 7, GPIO 8", + {0x30,0xe0,0xe1,0xe2,0xe3,0xe4,0xe5,0xe6,0xe7,0xec,0xed,0xf4,0xf5,0xf6,0xf7,0xf8,EOT}, + {0x00,0x7f,NANA,0x00,NANA,0xff,NANA,0x00,NANA,0x00,0x00,0xff,NANA,0x00,NANA,0x00,EOT}}, + {0x08, "WDT1, WDT_MEM, GPIO 0, GPIO 1", + {0x30,0x60,0x61,0xe0,0xe1,0xe2,0xe3,0xe4,0xf0,0xf1,0xf2,0xf3,0xf4,0xf5,0xf6,0xf7,0xf8,0xf9,0xfa,0xfe,0xff,EOT}, + {0x00,0x00,0x00,0xff,NANA,0x00,NANA,0x00,0xff,NANA,0x00,NANA,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,EOT}}, + {0x09, "GPIO 2, GPIO 3, GPIO 4, GPIO 5", + {0x30,0xe0,0xe1,0xe2,0xe3,0xe4,0xe5,0xe6,0xe7,0xe8,0xe9,0xea,0xeb,0xee,0xf0,0xf1,0xf2,0xf4,0xf5,0xf6,0xf7,0xfe,EOT}, + {0x00,0xff,NANA,0x00,NANA,0x7f,NANA,0x00,NANA,NANA,0x00,0x00,0x00,0x00,0xff,NANA,0x00,0xff,NANA,0x00,NANA,0x00,EOT}}, + {0x0a, "ACPI", + {0xe0,0xe1,0xe2,0xe3,0xe4,0xe5,0xe6,0xe7,0xe9,0xec,0xed,0xee,0xf0,0xf2,0xf3,0xf4,0xf6,0xf7,0xfc,0xfe,EOT}, + {0x01,0x00,0x00,0x00,0x00,0x02,0x1a,0x00,0x00,0x00,0x00,0x00,0x10,0x5c,0x00,0x00,0x00,0xc0,0x00,0x00,EOT}}, + {0x0b, "Hardware Monitor, Front Panel LED", + {0x30,0x60,0x61,0x62,0x63,0x70,0xe0,0xe1,0xe2,0xe3,0xe4,0xe6,0xe7,0xf0,0xf1,0xf2,0xf5,0xf6,0xf7,0xf8,0xf9,0xfa,0xfb,EOT}, + {0x00,0x00,0x00,0x00,0x00,0x00,0x7f,0x7f,0xff,0xff,0xff,0x08,0xff,0x00,0x00,0x00,0x10,0x00,0x87,0x47,0x00,0x00,0x00,EOT}}, + {0x0d, "BCLK, WDT2, WDT_MEM", + {0xe0,0xe1,0xe7,0xe8,0xeb,0xed,0xf0,0xf3,EOT}, + {0x00,MISC,0x00,0x32,0x14,0x00,0x00,0x00,EOT}}, + {0x0e, "CIR Wake-Up", + {0x30,0x60,0x61,0x70,EOT}, + {0x00,0x00,0x00,0x00,EOT}}, + {0x0f, "GPIO Push-Pull or Open-Drain selection", + {0xe0,0xe1,0xe2,0xe3,0xe4,0xe5,0xe6,0xe7,0xe9,0xf0,0xf1,0xf2,EOT}, + {0xff,0xff,0x7f,0xff,0xff,0xff,0x0f,0xff,0xff,0x9d,0x00,0x00,EOT}}, + {0x14, "Port 80 UART", + {0xe0,0xe1,0xe2,0xe3,0xe4,EOT}, + {0x80,0x00,0x00,0x10,0x00,EOT}}, + {0x16, "Deep Sleep", + {0x30,0xe0,0xe1,0xe2,0xe3,EOT}, + {0x20,0x20,0x04,0x05,0x01,EOT}}, + {EOT}}}, {0xd121, "NCT5539D", { {NOLDN, NULL, {0x10,0x11,0x13,0x14,0x1a,0x1b,0x1c,0x1d,0x22,0x24,
-
Angel Pons (Code Review) -
Clay Daniels (Code Review)
-
Felix Held (Code Review)
-
Nico Huber (Code Review)
-
Paul Menzel (Code Review)