Attention is currently required from: Andrey Petrov, Arthur Heymans, Kapil Porwal, Nick Vaccaro.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81621?usp=email )
Change subject: drivers/intel: Align FSP debug handler with EFI calling convention
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
When mixing 32bit FSP with 64bit coreboot using trampolines, this might not work so well: see https://review.coreboot.org/c/coreboot/+/79823 . Any thoughts?
To be clear, that code was WIP and does not work yet, so it should not be stalling your effort here. Just wondering what your take would be on this.
Thanks for sharing the CL.
So far (this patch train and few are in another thread) we are testing 32-bit FSP with 32-bit build/booting and likewise for 64-bit FSP/coreboot combination. There are CLs in the pipeline that we are testing to complete the Meteor Lake 64-bit transition as POC. Featurewise there is no regression.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81621?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9085a6c7d50e58fb56cbbc61da3a0af094d0dc05
Gerrit-Change-Number: 81621
Gerrit-PatchSet: 4
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Comment-Date: Thu, 04 Apr 2024 06:27:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment