Change in coreboot[master]: device/mmio.h: Add more bit field helpers

[Hung-Te Lin (Code Review)]

Hung-Te Lin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35787 )

Change subject: device/mmio.h: Add more bit field helpers
......................................................................

device/mmio.h: Add more bit field helpers

For fields with single bit, it's easier to declare as

DEFINE_BIT(name, bit)

Change-Id: If20e6b1809073b2c0dc84190edc25b207bf332b7
Signed-off-by: Hung-Te Lin 
---
M src/include/device/mmio.h
1 file changed, 7 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/35787/1

diff --git a/src/include/device/mmio.h b/src/include/device/mmio.h
index 7b95a3c..df36eb6 100644
--- a/src/include/device/mmio.h
+++ b/src/include/device/mmio.h
@@ -63,6 +63,10 @@
  *  - high_bit: highest bit that's part of the bit field.
  *  - low_bit: lowest bit in the bit field.
  *
+ * To define a field with a single bit:
+ *
+ *  DEFINE_BIT(name, bit)
+ *
  * To extract one field value from a raw reg value:
  *
  *  EXTRACT_BITFIELD(value, name);
@@ -85,7 +89,7 @@
  * Examples:
  *
  *  DEFINE_BITFIELD(DISP_TYPE, 2, 1)
- *  DEFINE_BITFIELD(DISP_EN, 0, 0)
+ *  DEFINE_BIT(DISP_EN, 0)
  *
  *  SET32_BITFIELDS(&disp_regs.ctrl, DISP_TYPE, 2);
  *  SET32_BITFIELDS(&disp_regs.ctrl, DISP_EN, 0);
@@ -118,6 +122,8 @@
    	name##_BITFIELD_SIZE = (high_bit) - (low_bit) + 1, \
    };

+#define DEFINE_BIT(name, bit) DEFINE_BITFIELD(name, bit, bit)
+
 #define _BF_MASK(name, value) \
    (((1 << name##_BITFIELD_SIZE) - 1) << name##_BITFIELD_SHIFT)

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35787 )

Change subject: device/mmio.h: Add more bit field helpers
......................................................................

Patch Set 1: Code-Review+2

[Yu-Ping Wu (Code Review)]

Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35787 )

Change subject: device/mmio.h: Add more bit field helpers
......................................................................

Patch Set 1: Code-Review+1

[Werner Zeh (Code Review)]

Werner Zeh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35787 )

Change subject: device/mmio.h: Add more bit field helpers
......................................................................

device/mmio.h: Add more bit field helpers

For fields with single bit, it's easier to declare as

DEFINE_BIT(name, bit)

Change-Id: If20e6b1809073b2c0dc84190edc25b207bf332b7
Signed-off-by: Hung-Te Lin 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/35787
Tested-by: build bot (Jenkins) 
Reviewed-by: Julius Werner 
Reviewed-by: Yu-Ping Wu 
---
M src/include/device/mmio.h
1 file changed, 7 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Julius Werner: Looks good to me, approved
  Yu-Ping Wu: Looks good to me, but someone else must approve

diff --git a/src/include/device/mmio.h b/src/include/device/mmio.h
index 7b95a3c..df36eb6 100644
--- a/src/include/device/mmio.h
+++ b/src/include/device/mmio.h
@@ -63,6 +63,10 @@
  *  - high_bit: highest bit that's part of the bit field.
  *  - low_bit: lowest bit in the bit field.
  *
+ * To define a field with a single bit:
+ *
+ *  DEFINE_BIT(name, bit)
+ *
  * To extract one field value from a raw reg value:
  *
  *  EXTRACT_BITFIELD(value, name);
@@ -85,7 +89,7 @@
  * Examples:
  *
  *  DEFINE_BITFIELD(DISP_TYPE, 2, 1)
- *  DEFINE_BITFIELD(DISP_EN, 0, 0)
+ *  DEFINE_BIT(DISP_EN, 0)
  *
  *  SET32_BITFIELDS(&disp_regs.ctrl, DISP_TYPE, 2);
  *  SET32_BITFIELDS(&disp_regs.ctrl, DISP_EN, 0);
@@ -118,6 +122,8 @@
    	name##_BITFIELD_SIZE = (high_bit) - (low_bit) + 1, \
    };

+#define DEFINE_BIT(name, bit) DEFINE_BITFIELD(name, bit, bit)
+
 #define _BF_MASK(name, value) \
    (((1 << name##_BITFIELD_SIZE) - 1) << name##_BITFIELD_SHIFT)