Martin Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/68227 )
Change subject: soc/amd/mendocino/psp_verstage: Remove TODO comment ......................................................................
soc/amd/mendocino/psp_verstage: Remove TODO comment
PSP verstage has been successfully enabled and this makefile looks good. Hence removing a TODO comment.
BUG=b:239090306 TEST=Build Skyrim BIOS image.
Signed-off-by: Karthikeyan Ramasubramanian kramasub@google.com Change-Id: Ic3cd55171fd1e4d74fac72f0b0b92dc80e533b5c Reviewed-on: https://review.coreboot.org/c/coreboot/+/68227 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Jon Murphy jpmurphy@google.com Reviewed-by: Fred Reitberger reitbergerfred@gmail.com --- M src/soc/amd/mendocino/psp_verstage/Makefile.inc 1 file changed, 20 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Jon Murphy: Looks good to me, approved Fred Reitberger: Looks good to me, but someone else must approve
diff --git a/src/soc/amd/mendocino/psp_verstage/Makefile.inc b/src/soc/amd/mendocino/psp_verstage/Makefile.inc index b6819a1..b185ffd 100644 --- a/src/soc/amd/mendocino/psp_verstage/Makefile.inc +++ b/src/soc/amd/mendocino/psp_verstage/Makefile.inc @@ -1,7 +1,5 @@ # SPDX-License-Identifier: GPL-2.0-only
-# TODO(b/239090306): Check if this is still correct - verstage-generic-ccopts += -I$(src)/soc/amd/mendocino/psp_verstage/include verstage-generic-ccopts += -I$(src)/vendorcode/amd/fsp/mendocino/include
-
Martin Roth (Code Review)