Change in ...coreboot[master]: nb/intel/gm45: Use a common romstage - coreboot-gerrit

6 Feb 2019


      Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31190 )
Change subject: nb/intel/gm45: Use a common romstage
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/31190/4/src/mainboard/roda/rk9/romstage.c 
File src/mainboard/roda/rk9/romstage.c:
https://review.coreboot.org/#/c/31190/4/src/mainboard/roda/rk9/romstage.c@86 
PS4, Line 86: 0x50
It would be great to place those values in devicetree, but that's out of scope of this patch.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/31190
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I30ef7f6962aabde78b5c40e0b53bb85e01c254c1
Gerrit-Change-Number: 31190
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 06 Feb 2019 07:16:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment