Joel Kitching has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40326 )
Change subject: libpayload/cbfs_core: add arch/types.h include ......................................................................
libpayload/cbfs_core: add arch/types.h include
cbfs_core.h uses u32, so it should include arch/types.h.
BUG=chromium:1070071 TEST=make clean && make test-abuild BRANCH=none
Change-Id: Ibcfbb8dbd20570292dcc06ccb73cf8a7cfe15d8d Signed-off-by: Joel Kitching kitching@google.com --- M payloads/libpayload/include/cbfs_core.h 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/40326/1
diff --git a/payloads/libpayload/include/cbfs_core.h b/payloads/libpayload/include/cbfs_core.h index ad1e9e2..f03eaf6 100644 --- a/payloads/libpayload/include/cbfs_core.h +++ b/payloads/libpayload/include/cbfs_core.h @@ -46,6 +46,7 @@ #ifndef _CBFS_CORE_H_ #define _CBFS_CORE_H_
+#include <arch/types.h> #include <endian.h> #include <stddef.h> #include <stdint.h>
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40326 )
Change subject: libpayload/cbfs_core: add arch/types.h include ......................................................................
Patch Set 1:
I think the canonical thing to include here is <stdint.h> (or just <libpayload.h>).
Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40326 )
Change subject: libpayload/cbfs_core: add arch/types.h include ......................................................................
Patch Set 1:
Patch Set 1:
I think the canonical thing to include here is <stdint.h> (or just <libpayload.h>).
Seems like a lot of libpayload/include headers have arch/types.h. Should this be fixed?
./cbgfx.h:#include <arch/types.h> ./stdint.h:#include <arch/types.h> ./sys/types.h:#include <arch/types.h> ./endian.h:#include <arch/types.h> ./cbfs_core.h:#include <arch/types.h> ./libpayload.h:#include <arch/types.h> ./coreboot_tables.h:#include <arch/types.h> ./stddef.h:#include <arch/types.h> ./pci.h:#include <arch/types.h> ./multiboot_tables.h:#include <arch/types.h>
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40326 )
Change subject: libpayload/cbfs_core: add arch/types.h include ......................................................................
Patch Set 1:
Seems like a lot of libpayload/include headers have arch/types.h. Should this be fixed?
./cbgfx.h:#include <arch/types.h> ./stdint.h:#include <arch/types.h> ./sys/types.h:#include <arch/types.h> ./endian.h:#include <arch/types.h> ./cbfs_core.h:#include <arch/types.h> ./libpayload.h:#include <arch/types.h> ./coreboot_tables.h:#include <arch/types.h> ./stddef.h:#include <arch/types.h> ./pci.h:#include <arch/types.h> ./multiboot_tables.h:#include <arch/types.h>
Probably.
Joel Kitching has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/40326 )
Change subject: libpayload/cbfs_core: add arch/types.h include ......................................................................
Abandoned
It's not really clear what should be done here... each header file includes different things. So I'll just leave it as-is.
-
Joel Kitching (Code Review) -
Julius Werner (Code Review)