Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/71199 )
Change subject: soc/intel/baytrail: add _HRV to I2C ACPI devices ......................................................................
soc/intel/baytrail: add _HRV to I2C ACPI devices
For some reason, the Windows i2c drivers won't attach without _HRV (hardware version) defined for the i2c controllers. Add it, using value taken from Intel baytrail/valleyview edk2 reference code.
TEST=boot Windows 10/11 on google/rambi, verify i2c drivers load properly.
Change-Id: I590acd1f1b75f6bf2bf278e67eec1dcc24bcc15d Signed-off-by: Matt DeVillier matt.devillier@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/71199 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/soc/intel/baytrail/acpi/lpss.asl 1 file changed, 35 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/soc/intel/baytrail/acpi/lpss.asl b/src/soc/intel/baytrail/acpi/lpss.asl index 113d5c0..b8e2d96 100644 --- a/src/soc/intel/baytrail/acpi/lpss.asl +++ b/src/soc/intel/baytrail/acpi/lpss.asl @@ -94,6 +94,8 @@ Return (^RBUF) }
+ Method (_HRV, 0, NotSerialized) { Return (0x06) } + Method (_STA) { If (\S1EN == 1) { @@ -153,6 +155,8 @@ Return (^RBUF) }
+ Method (_HRV, 0, NotSerialized) { Return (0x06) } + Method (_STA) { If (\S2EN == 1) { @@ -205,6 +209,8 @@ FixedDMA (0x15, 0x5, Width32Bit, ) })
+ Method (_HRV, 0, NotSerialized) { Return (0x06) } + Method (_CRS) { CreateDwordField (^RBUF, ^BAR0._BAS, RBAS) @@ -271,6 +277,8 @@ Return (^RBUF) }
+ Method (_HRV, 0, NotSerialized) { Return (0x06) } + Method (_STA) { If (\S4EN == 1) { @@ -330,6 +338,8 @@ Return (^RBUF) }
+ Method (_HRV, 0, NotSerialized) { Return (0x06) } + Method (_STA) { If (\S5EN == 1) { @@ -389,6 +399,8 @@ Return (^RBUF) }
+ Method (_HRV, 0, NotSerialized) { Return (0x06) } + Method (_STA) { If (\S6EN == 1) { @@ -448,6 +460,8 @@ Return (^RBUF) }
+ Method (_HRV, 0, NotSerialized) { Return (0x06) } + Method (_STA) { If (\S7EN == 1) {