Attention is currently required from: Jason Glenesk, Raul Rangel, Martin Roth, Julius Werner.
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50403 )
Change subject: soc/amd/common/block: Fix guards for PSP transfer buffer
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File src/soc/amd/common/block/cpu/noncar/memlayout_transfer_buffer.inc:
https://review.coreboot.org/c/coreboot/+/50403/comment/8b12a30c_19064a72
PS1, Line 9: #if CONFIG(VBOOT_STARTS_BEFORE_BOOTBLOCK) || CONFIG(VBOOT_STARTS_IN_BOOTBLOCK)
Nit: I wonder if CONFIG(VBOOT) would do just as well here. AFAICS the only other option is STARTS_IN_ROMSTAGE for some older devices, and that's not something we care about for a "nocar" platform.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50403
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I444bede3f2b716e1900e7621453351d7fddadaa3
Gerrit-Change-Number: 50403
Gerrit-PatchSet: 1
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Tue, 09 Feb 2021 02:33:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment