HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37366 )
Change subject: src: Add missing include <stdlib.h> ......................................................................
src: Add missing include <stdlib.h>
Also use <types.h> when <stdint.h> and <stddef.h> are needed. Also add some missing includes spotted by Jenkins.
Change-Id: I17dc2fed6c6518daf5af286788c98c049088911e Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/commonlib/storage/bouncebuf.c M src/commonlib/storage/sdhci.c M src/commonlib/storage/sdhci_adma.c M src/device/oprom/yabel/vbe.c M src/lib/fit_payload.c M src/mainboard/emulation/qemu-i440fx/fw_cfg.c M src/northbridge/intel/pineview/raminit.c M src/northbridge/intel/sandybridge/raminit_common.c M src/soc/amd/common/block/spi/fch_spi_flash.c M src/soc/intel/broadwell/me.c M src/soc/intel/common/block/fast_spi/fast_spi_flash.c M src/soc/intel/common/smbios.c M src/soc/intel/quark/i2c.c M src/soc/intel/skylake/elog.c M src/vendorcode/cavium/bdk/libbdk-hal/bdk-config.c M src/vendorcode/cavium/bdk/libbdk-hal/bdk-qlm.c M src/vendorcode/cavium/bdk/libbdk-hal/device/bdk-device.c M src/vendorcode/cavium/bdk/libdram/dram-tune-ddr3.c 18 files changed, 42 insertions(+), 12 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/37366/1
diff --git a/src/commonlib/storage/bouncebuf.c b/src/commonlib/storage/bouncebuf.c index 99287b6..6244896 100644 --- a/src/commonlib/storage/bouncebuf.c +++ b/src/commonlib/storage/bouncebuf.c @@ -15,10 +15,13 @@ */
#include <arch/cache.h> +#include <commonlib/stdlib.h> +#include <stdlib.h> +#include <string.h> +#include <types.h> + #include "bouncebuf.h" #include "storage.h" -#include <string.h> -#include <commonlib/stdlib.h>
static int addr_aligned(struct bounce_buffer *state) { diff --git a/src/commonlib/storage/sdhci.c b/src/commonlib/storage/sdhci.c index 25c0d6f1e..25d0f2f 100644 --- a/src/commonlib/storage/sdhci.c +++ b/src/commonlib/storage/sdhci.c @@ -14,17 +14,20 @@ * Secure Digital (SD) Host Controller interface specific code */
-#include "bouncebuf.h" #include <commonlib/sd_mmc_ctrlr.h> #include <commonlib/sdhci.h> #include <commonlib/storage.h> #include <delay.h> #include <endian.h> +#include <timer.h> +#include <commonlib/stdlib.h> +#include <stdlib.h> +#include <types.h> + +#include "bouncebuf.h" #include "sdhci.h" #include "sd_mmc.h" #include "storage.h" -#include <timer.h> -#include <commonlib/stdlib.h>
#define DMA_AVAILABLE ((CONFIG(SDHCI_ADMA_IN_BOOTBLOCK) && ENV_BOOTBLOCK) \ || (CONFIG(SDHCI_ADMA_IN_VERSTAGE) && ENV_VERSTAGE) \ diff --git a/src/commonlib/storage/sdhci_adma.c b/src/commonlib/storage/sdhci_adma.c index 2806bde..7738afb 100644 --- a/src/commonlib/storage/sdhci_adma.c +++ b/src/commonlib/storage/sdhci_adma.c @@ -19,6 +19,8 @@ #include <console/console.h> #include <delay.h> #include <endian.h> +#include <stdlib.h> +#include <stdint.h> #include <string.h>
#include "sdhci.h" diff --git a/src/device/oprom/yabel/vbe.c b/src/device/oprom/yabel/vbe.c index a3d736f..7d1ea59 100644 --- a/src/device/oprom/yabel/vbe.c +++ b/src/device/oprom/yabel/vbe.c @@ -34,6 +34,7 @@
#include <boot/coreboot_tables.h> #include <string.h> +#include <stdlib.h> #include <types.h>
#include <endian.h> diff --git a/src/lib/fit_payload.c b/src/lib/fit_payload.c index 1b6c986..ccb84f4 100644 --- a/src/lib/fit_payload.c +++ b/src/lib/fit_payload.c @@ -19,12 +19,13 @@ #include <bootmem.h> #include <cbmem.h> #include <device/resource.h> -#include <stdlib.h> #include <commonlib/region.h> #include <fit.h> #include <program_loading.h> #include <timestamp.h> +#include <stdlib.h> #include <string.h> +#include <types.h> #include <commonlib/cbfs_serialized.h> #include <commonlib/compression.h> #include <lib.h> diff --git a/src/mainboard/emulation/qemu-i440fx/fw_cfg.c b/src/mainboard/emulation/qemu-i440fx/fw_cfg.c index 580e09a..50123f9 100644 --- a/src/mainboard/emulation/qemu-i440fx/fw_cfg.c +++ b/src/mainboard/emulation/qemu-i440fx/fw_cfg.c @@ -12,6 +12,7 @@ */
#include <endian.h> +#include <stdlib.h> #include <string.h> #include <smbios.h> #include <console/console.h> diff --git a/src/northbridge/intel/pineview/raminit.c b/src/northbridge/intel/pineview/raminit.c index 7f59d91..0deaff6 100644 --- a/src/northbridge/intel/pineview/raminit.c +++ b/src/northbridge/intel/pineview/raminit.c @@ -21,10 +21,12 @@ #include <cpu/x86/cache.h> #include <delay.h> #include <lib.h> +#include <spd.h> +#include <stdlib.h> +#include <string.h> + #include "pineview.h" #include "raminit.h" -#include <spd.h> -#include <string.h>
/* Debugging macros. */ #if CONFIG(DEBUG_RAM_SETUP) diff --git a/src/northbridge/intel/sandybridge/raminit_common.c b/src/northbridge/intel/sandybridge/raminit_common.c index 4974173..26338d6 100644 --- a/src/northbridge/intel/sandybridge/raminit_common.c +++ b/src/northbridge/intel/sandybridge/raminit_common.c @@ -23,6 +23,7 @@ #include <northbridge/intel/sandybridge/chip.h> #include <device/pci_def.h> #include <delay.h> +#include <stdlib.h>
#include "raminit_native.h" #include "raminit_common.h" diff --git a/src/soc/amd/common/block/spi/fch_spi_flash.c b/src/soc/amd/common/block/spi/fch_spi_flash.c index 40dd0e2..5942e77 100644 --- a/src/soc/amd/common/block/spi/fch_spi_flash.c +++ b/src/soc/amd/common/block/spi/fch_spi_flash.c @@ -19,6 +19,7 @@ #include <amdblocks/fch_spi.h> #include <drivers/spi/spi_flash_internal.h> #include <timer.h> +#include <stdlib.h> #include <string.h>
static void spi_flash_addr(u32 addr, u8 *cmd) diff --git a/src/soc/intel/broadwell/me.c b/src/soc/intel/broadwell/me.c index 0021d2c..774f2bc 100644 --- a/src/soc/intel/broadwell/me.c +++ b/src/soc/intel/broadwell/me.c @@ -39,7 +39,7 @@ #include <soc/ramstage.h> #include <soc/rcba.h> #include <soc/intel/broadwell/chip.h> - +#include <stdlib.h> #if CONFIG(CHROMEOS) #include <vendorcode/google/chromeos/chromeos.h> #include <vendorcode/google/chromeos/gnvs.h> diff --git a/src/soc/intel/common/block/fast_spi/fast_spi_flash.c b/src/soc/intel/common/block/fast_spi/fast_spi_flash.c index 0a43442..2f86940 100644 --- a/src/soc/intel/common/block/fast_spi/fast_spi_flash.c +++ b/src/soc/intel/common/block/fast_spi/fast_spi_flash.c @@ -19,8 +19,10 @@ #include <intelblocks/fast_spi.h> #include <soc/pci_devs.h> #include <spi_flash.h> +#include <stdlib.h> #include <string.h> #include <timer.h> +#include <types.h>
/* Helper to create a FAST_SPI context on API entry. */ #define BOILERPLATE_CREATE_CTX(ctx) \ diff --git a/src/soc/intel/common/smbios.c b/src/soc/intel/common/smbios.c index d315e15..a468abb 100644 --- a/src/soc/intel/common/smbios.c +++ b/src/soc/intel/common/smbios.c @@ -13,11 +13,14 @@ * GNU General Public License for more details. */
-#include <smbios.h> -#include "smbios.h" -#include <string.h> #include <console/console.h> #include <device/dram/ddr3.h> +#include <smbios.h> +#include <stdlib.h> +#include <string.h> +#include <types.h> + +#include "smbios.h"
/* Fill the SMBIOS memory information from FSP MEM_INFO_DATA_HOB in CBMEM.*/ void dimm_info_fill(struct dimm_info *dimm, u32 dimm_capacity, u8 ddr_type, diff --git a/src/soc/intel/quark/i2c.c b/src/soc/intel/quark/i2c.c index b09852b..ad6418f 100644 --- a/src/soc/intel/quark/i2c.c +++ b/src/soc/intel/quark/i2c.c @@ -22,6 +22,8 @@ #include <soc/i2c.h> #include <soc/ramstage.h> #include <soc/reg_access.h> +#include <stdint.h> +#include <stdlib.h> #include <timer.h>
static void i2c_disable(I2C_REGS *regs) diff --git a/src/soc/intel/skylake/elog.c b/src/soc/intel/skylake/elog.c index 7951394..7871d7d 100644 --- a/src/soc/intel/skylake/elog.c +++ b/src/soc/intel/skylake/elog.c @@ -20,6 +20,7 @@ #include <device/mmio.h> #include <device/pci_ops.h> #include <stdint.h> +#include <stdlib.h> #include <elog.h> #include <intelblocks/pmclib.h> #include <intelblocks/xhci.h> diff --git a/src/vendorcode/cavium/bdk/libbdk-hal/bdk-config.c b/src/vendorcode/cavium/bdk/libbdk-hal/bdk-config.c index e078e74..cc6a5dd 100644 --- a/src/vendorcode/cavium/bdk/libbdk-hal/bdk-config.c +++ b/src/vendorcode/cavium/bdk/libbdk-hal/bdk-config.c @@ -12,6 +12,7 @@
#include <bdk.h> #include <libbdk-hal/bdk-config.h> +#include <stdlib.h> #include <string.h> #include <assert.h> #include <lame_string.h> diff --git a/src/vendorcode/cavium/bdk/libbdk-hal/bdk-qlm.c b/src/vendorcode/cavium/bdk/libbdk-hal/bdk-qlm.c index b9552d4..810a0ed 100644 --- a/src/vendorcode/cavium/bdk/libbdk-hal/bdk-qlm.c +++ b/src/vendorcode/cavium/bdk/libbdk-hal/bdk-qlm.c @@ -37,7 +37,9 @@ * ARISING OUT OF USE OR PERFORMANCE OF THE SOFTWARE LIES WITH YOU. ***********************license end**************************************/ #include <bdk.h> +#include <stdlib.h> #include <string.h> + #include "libbdk-arch/bdk-csrs-gser.h" #include "libbdk-arch/bdk-csrs-gsern.h" #include "libbdk-hal/if/bdk-if.h" diff --git a/src/vendorcode/cavium/bdk/libbdk-hal/device/bdk-device.c b/src/vendorcode/cavium/bdk/libbdk-hal/device/bdk-device.c index 0df70eb..ed003dc 100644 --- a/src/vendorcode/cavium/bdk/libbdk-hal/device/bdk-device.c +++ b/src/vendorcode/cavium/bdk/libbdk-hal/device/bdk-device.c @@ -36,8 +36,11 @@ * QUIET POSSESSION OR CORRESPONDENCE TO DESCRIPTION. THE ENTIRE RISK * ARISING OUT OF USE OR PERFORMANCE OF THE SOFTWARE LIES WITH YOU. ***********************license end**************************************/ + #include <bdk.h> #include <string.h> +#include <stdlib.h> + #include "libbdk-arch/bdk-csrs-ap.h" #include "libbdk-arch/bdk-csrs-pccpf.h" #include "libbdk-hal/bdk-ecam.h" diff --git a/src/vendorcode/cavium/bdk/libdram/dram-tune-ddr3.c b/src/vendorcode/cavium/bdk/libdram/dram-tune-ddr3.c index 291fe85..445ada8 100644 --- a/src/vendorcode/cavium/bdk/libdram/dram-tune-ddr3.c +++ b/src/vendorcode/cavium/bdk/libdram/dram-tune-ddr3.c @@ -40,6 +40,7 @@ #include "dram-internal.h"
#include <string.h> +#include <stdlib.h> #include <lame_string.h> /* for strtoul */ #include <libbdk-hal/bdk-atomic.h> #include <libbdk-hal/bdk-clock.h>
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37366 )
Change subject: src: Add missing include <stdlib.h> ......................................................................
Patch Set 1:
This change is ready for review.
Hello Patrick Rudolph, build bot (Jenkins), Damien Zammit,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37366
to look at the new patch set (#2).
Change subject: src: Add missing include <stdlib.h> ......................................................................
src: Add missing include <stdlib.h>
Change-Id: I17dc2fed6c6518daf5af286788c98c049088911e Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/arch/x86/acpi_device.c M src/mainboard/emulation/qemu-i440fx/fw_cfg.c M src/mainboard/sifive/hifive-unleashed/fixup_fdt.c M src/northbridge/intel/pineview/raminit.c M src/northbridge/intel/sandybridge/raminit_common.c M src/soc/amd/common/block/spi/fch_spi_flash.c M src/soc/intel/broadwell/me.c M src/soc/intel/common/block/fast_spi/fast_spi_flash.c M src/soc/intel/common/smbios.c M src/soc/intel/quark/i2c.c M src/soc/intel/skylake/elog.c 11 files changed, 11 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/37366/2
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37366 )
Change subject: src: Add missing include <stdlib.h> ......................................................................
Patch Set 2:
(11 comments)
https://review.coreboot.org/c/coreboot/+/37366/2/src/arch/x86/acpi_device.c File src/arch/x86/acpi_device.c:
https://review.coreboot.org/c/coreboot/+/37366/2/src/arch/x86/acpi_device.c@... PS2, Line 729: malloc needs #include <stdlib.h>
https://review.coreboot.org/c/coreboot/+/37366/2/src/mainboard/emulation/qem... File src/mainboard/emulation/qemu-i440fx/fw_cfg.c:
https://review.coreboot.org/c/coreboot/+/37366/2/src/mainboard/emulation/qem... PS2, Line 248: malloc needs #include <stdlib.h>
https://review.coreboot.org/c/coreboot/+/37366/2/src/mainboard/sifive/hifive... File src/mainboard/sifive/hifive-unleashed/fixup_fdt.c:
https://review.coreboot.org/c/coreboot/+/37366/2/src/mainboard/sifive/hifive... PS2, Line 103: malloc( needs #include <stdlib.h>
https://review.coreboot.org/c/coreboot/+/37366/2/src/northbridge/intel/pinev... File src/northbridge/intel/pineview/raminit.c:
https://review.coreboot.org/c/coreboot/+/37366/2/src/northbridge/intel/pinev... PS2, Line 459: max( needs #include <stdlib.h>
https://review.coreboot.org/c/coreboot/+/37366/2/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/raminit_common.c:
https://review.coreboot.org/c/coreboot/+/37366/2/src/northbridge/intel/sandy... PS2, Line 1464: max( needs #include <stdlib.h>
https://review.coreboot.org/c/coreboot/+/37366/2/src/soc/amd/common/block/sp... File src/soc/amd/common/block/spi/fch_spi_flash.c:
https://review.coreboot.org/c/coreboot/+/37366/2/src/soc/amd/common/block/sp... PS2, Line 34: min( needs #include <stdlib.h>
https://review.coreboot.org/c/coreboot/+/37366/2/src/soc/intel/broadwell/me.... File src/soc/intel/broadwell/me.c:
https://review.coreboot.org/c/coreboot/+/37366/2/src/soc/intel/broadwell/me.... PS2, Line 961: free( needs #include <stdlib.h>
https://review.coreboot.org/c/coreboot/+/37366/2/src/soc/intel/common/block/... File src/soc/intel/common/block/fast_spi/fast_spi_flash.c:
https://review.coreboot.org/c/coreboot/+/37366/2/src/soc/intel/common/block/... PS2, Line 160: min( needs #include <stdlib.h>
https://review.coreboot.org/c/coreboot/+/37366/2/src/soc/intel/common/smbios... File src/soc/intel/common/smbios.c:
https://review.coreboot.org/c/coreboot/+/37366/2/src/soc/intel/common/smbios... PS2, Line 66: min( needs #include <stdlib.h>
https://review.coreboot.org/c/coreboot/+/37366/2/src/soc/intel/quark/i2c.c File src/soc/intel/quark/i2c.c:
https://review.coreboot.org/c/coreboot/+/37366/2/src/soc/intel/quark/i2c.c@a... PS2, Line 136: min( needs #include <stdlib.h>
https://review.coreboot.org/c/coreboot/+/37366/2/src/soc/intel/skylake/elog.... File src/soc/intel/skylake/elog.c:
https://review.coreboot.org/c/coreboot/+/37366/2/src/soc/intel/skylake/elog.... PS2, Line 159: min( needs #include <stdlib.h>
Hello Patrick Rudolph, ron minnich, build bot (Jenkins), Philipp Hug, Damien Zammit,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37366
to look at the new patch set (#3).
Change subject: src: Add missing include <stdlib.h> ......................................................................
src: Add missing include <stdlib.h>
Change-Id: I17dc2fed6c6518daf5af286788c98c049088911e Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/arch/x86/acpi_device.c M src/commonlib/storage/sdhci_adma.c M src/mainboard/emulation/qemu-i440fx/fw_cfg.c M src/mainboard/sifive/hifive-unleashed/fixup_fdt.c M src/northbridge/intel/pineview/raminit.c M src/northbridge/intel/sandybridge/raminit_common.c M src/soc/amd/common/block/spi/fch_spi_flash.c M src/soc/intel/broadwell/me.c M src/soc/intel/common/block/fast_spi/fast_spi_flash.c M src/soc/intel/common/smbios.c M src/soc/intel/quark/i2c.c M src/soc/intel/skylake/elog.c 12 files changed, 12 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/37366/3
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37366 )
Change subject: src: Add missing include <stdlib.h> ......................................................................
Patch Set 3:
easy to review .... see comments on 'Patch Set 2' Thank you.
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37366 )
Change subject: src: Add missing include <stdlib.h> ......................................................................
Patch Set 4:
(12 comments)
commented to make this very easy to review.
https://review.coreboot.org/c/coreboot/+/37366/4/src/arch/x86/acpi_device.c File src/arch/x86/acpi_device.c:
https://review.coreboot.org/c/coreboot/+/37366/4/src/arch/x86/acpi_device.c@... PS4, Line 730: malloc needs #include <stdlib.h>
https://review.coreboot.org/c/coreboot/+/37366/4/src/commonlib/storage/sdhci... File src/commonlib/storage/sdhci_adma.c:
https://review.coreboot.org/c/coreboot/+/37366/4/src/commonlib/storage/sdhci... PS4, Line 35: free needs #include <stdlib.h>
https://review.coreboot.org/c/coreboot/+/37366/4/src/mainboard/emulation/qem... File src/mainboard/emulation/qemu-i440fx/fw_cfg.c:
https://review.coreboot.org/c/coreboot/+/37366/4/src/mainboard/emulation/qem... PS4, Line 249: malloc needs #include <stdlib.h>
https://review.coreboot.org/c/coreboot/+/37366/4/src/mainboard/sifive/hifive... File src/mainboard/sifive/hifive-unleashed/fixup_fdt.c:
https://review.coreboot.org/c/coreboot/+/37366/4/src/mainboard/sifive/hifive... PS4, Line 104: malloc needs #include <stdlib.h>
https://review.coreboot.org/c/coreboot/+/37366/4/src/northbridge/intel/pinev... File src/northbridge/intel/pineview/raminit.c:
https://review.coreboot.org/c/coreboot/+/37366/4/src/northbridge/intel/pinev... PS4, Line 460: max needs #include <stdlib.h>
https://review.coreboot.org/c/coreboot/+/37366/4/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/raminit_common.c:
https://review.coreboot.org/c/coreboot/+/37366/4/src/northbridge/intel/sandy... PS4, Line 2723: min needs #include <stdlib.h>
https://review.coreboot.org/c/coreboot/+/37366/4/src/soc/amd/common/block/sp... File src/soc/amd/common/block/spi/fch_spi_flash.c:
https://review.coreboot.org/c/coreboot/+/37366/4/src/soc/amd/common/block/sp... PS4, Line 35: min( needs #include <stdlib.h>
https://review.coreboot.org/c/coreboot/+/37366/4/src/soc/intel/broadwell/me.... File src/soc/intel/broadwell/me.c:
https://review.coreboot.org/c/coreboot/+/37366/4/src/soc/intel/broadwell/me.... PS4, Line 875: mbp = malloc(mbp_hdr.mbp_size * sizeof(u32)); needs #include <stdlib.h>
https://review.coreboot.org/c/coreboot/+/37366/4/src/soc/intel/common/block/... File src/soc/intel/common/block/fast_spi/fast_spi_flash.c:
https://review.coreboot.org/c/coreboot/+/37366/4/src/soc/intel/common/block/... PS4, Line 161: min needs #include <stdlib.h>
https://review.coreboot.org/c/coreboot/+/37366/4/src/soc/intel/common/smbios... File src/soc/intel/common/smbios.c:
https://review.coreboot.org/c/coreboot/+/37366/4/src/soc/intel/common/smbios... PS4, Line 67: min needs #include <stdlib.h>
https://review.coreboot.org/c/coreboot/+/37366/4/src/soc/intel/quark/i2c.c File src/soc/intel/quark/i2c.c:
https://review.coreboot.org/c/coreboot/+/37366/4/src/soc/intel/quark/i2c.c@1... PS4, Line 137: min( needs #include <stdlib.h>
https://review.coreboot.org/c/coreboot/+/37366/4/src/soc/intel/skylake/elog.... File src/soc/intel/skylake/elog.c:
https://review.coreboot.org/c/coreboot/+/37366/4/src/soc/intel/skylake/elog.... PS4, Line 160: min( needs #include <stdlib.h>
Hello Werner Zeh, Patrick Rudolph, ron minnich, Felix Held, build bot (Jenkins), Philipp Hug, Damien Zammit,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37366
to look at the new patch set (#5).
Change subject: src: Add missing include <stdlib.h> ......................................................................
src: Add missing include <stdlib.h>
Change-Id: I17dc2fed6c6518daf5af286788c98c049088911e Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/arch/x86/acpi_device.c M src/commonlib/storage/sdhci_adma.c M src/mainboard/emulation/qemu-i440fx/fw_cfg.c M src/mainboard/sifive/hifive-unleashed/fixup_fdt.c M src/soc/intel/broadwell/me.c 5 files changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/37366/5
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37366 )
Change subject: src: Add missing include <stdlib.h> ......................................................................
Patch Set 5: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37366 )
Change subject: src: Add missing include <stdlib.h> ......................................................................
src: Add missing include <stdlib.h>
Change-Id: I17dc2fed6c6518daf5af286788c98c049088911e Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/37366 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Werner Zeh werner.zeh@siemens.com --- M src/arch/x86/acpi_device.c M src/commonlib/storage/sdhci_adma.c M src/mainboard/emulation/qemu-i440fx/fw_cfg.c M src/mainboard/sifive/hifive-unleashed/fixup_fdt.c M src/soc/intel/broadwell/me.c 5 files changed, 5 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Werner Zeh: Looks good to me, approved
diff --git a/src/arch/x86/acpi_device.c b/src/arch/x86/acpi_device.c index d367108..5c77953 100644 --- a/src/arch/x86/acpi_device.c +++ b/src/arch/x86/acpi_device.c @@ -17,6 +17,7 @@ #include <arch/acpigen.h> #include <device/device.h> #include <device/path.h> +#include <stdlib.h> #if CONFIG(GENERIC_GPIO_LIB) #include <gpio.h> #endif diff --git a/src/commonlib/storage/sdhci_adma.c b/src/commonlib/storage/sdhci_adma.c index 2806bde..2ca4b55 100644 --- a/src/commonlib/storage/sdhci_adma.c +++ b/src/commonlib/storage/sdhci_adma.c @@ -19,6 +19,7 @@ #include <console/console.h> #include <delay.h> #include <endian.h> +#include <stdlib.h> #include <string.h>
#include "sdhci.h" diff --git a/src/mainboard/emulation/qemu-i440fx/fw_cfg.c b/src/mainboard/emulation/qemu-i440fx/fw_cfg.c index 580e09a..50123f9 100644 --- a/src/mainboard/emulation/qemu-i440fx/fw_cfg.c +++ b/src/mainboard/emulation/qemu-i440fx/fw_cfg.c @@ -12,6 +12,7 @@ */
#include <endian.h> +#include <stdlib.h> #include <string.h> #include <smbios.h> #include <console/console.h> diff --git a/src/mainboard/sifive/hifive-unleashed/fixup_fdt.c b/src/mainboard/sifive/hifive-unleashed/fixup_fdt.c index 8ac6ff1..3d43181 100644 --- a/src/mainboard/sifive/hifive-unleashed/fixup_fdt.c +++ b/src/mainboard/sifive/hifive-unleashed/fixup_fdt.c @@ -14,6 +14,7 @@ */
#include <stdint.h> +#include <stdlib.h> #include <string.h> #include <console/console.h> #include <soc/otp.h> diff --git a/src/soc/intel/broadwell/me.c b/src/soc/intel/broadwell/me.c index 0021d2c..448c5da 100644 --- a/src/soc/intel/broadwell/me.c +++ b/src/soc/intel/broadwell/me.c @@ -29,6 +29,7 @@ #include <device/pci.h> #include <device/pci_ids.h> #include <device/pci_def.h> +#include <stdlib.h> #include <string.h> #include <delay.h> #include <elog.h>
-
HAOUAS Elyes (Code Review) -
Patrick Georgi (Code Review)
-
Werner Zeh (Code Review)