Attention is currently required from: Arthur Heymans, Chen, Gang C, Christian Walter, Johnny Lin, Jonathan Zhang, Lean Sheng Tan, Shuo Liu, Tim Chu, Ziang Wang.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81440?usp=email )
Change subject: soc/intel/xeon_sp: Add device to proximity domain map utils
......................................................................
Patch Set 6: Code-Review+1
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81440/comment/6de6c8eb_9323e62d :
PS6, Line 18: SNC
What does SNC mean? I would at least expand the acronym
File src/soc/intel/xeon_sp/numa.c:
https://review.coreboot.org/c/coreboot/+/81440/comment/ed054797_e85d0851 :
PS6, Line 122: uint32_t
Use `enum proximity_domain_type`. If it doesn't make sense (returned value is not a proximity domain **type**), then returning `PD_TYPE_MAX` in the error case is not correct.
https://review.coreboot.org/c/coreboot/+/81440/comment/3b490871_62e1b984 :
PS6, Line 130: return PD_TYPE_MAX;
Would it be a good idea to log a warning/error when the pd couldn't be found?
https://review.coreboot.org/c/coreboot/+/81440/comment/ef24c942_c288bf9a :
PS6, Line 147: return PD_TYPE_MAX;
Same here
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81440?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Icd14a98823491ccfc38473e44a26dddfbbcaa7c0
Gerrit-Change-Number: 81440
Gerrit-PatchSet: 6
Gerrit-Owner: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Chen, Gang C
gang.c.chen@intel.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: Ziang Wang
ziang.wang@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Attention: Chen, Gang C
gang.c.chen@intel.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Ziang Wang
ziang.wang@intel.com
Gerrit-Attention: Shuo Liu
shuo.liu@intel.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Mon, 29 Apr 2024 13:31:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment