Attention is currently required from: Angel Pons, Piotr Król.
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67940 )
Change subject: mb/protectli/vault_cml: Add Comet Lake 6 port board support ......................................................................
Patch Set 9:
(3 comments)
File Documentation/mainboard/protectli/vp46xx.md:
https://review.coreboot.org/c/coreboot/+/67940/comment/11b756e9_ab0c63f4 PS7, Line 68: - Super I/O serial port 0 via front microUSB connector
Yes, it does. Fintek F81232.
Added info about the adapter in this bulletpoint
https://review.coreboot.org/c/coreboot/+/67940/comment/45e7a8bc_0661c55b PS7, Line 90: ITE IT8786E/IT8784E
The configuration of the registers is the same when compared with the IT8786E datasheet. […]
Added a note on the beginning of this section.
File src/mainboard/protectli/vault_cml/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/67940/comment/1b4b3de5_6159b23b PS7, Line 228: "M.2/E 2230 (M2_WIFI2)" "SlotDataBusWidth1X"
nit: add an extra tab for visual alignment, `smbios_slot_desc ` is exactly 16 characters wide.
Done.