Change in ...coreboot[master]: soc/intel/broadwell: Move GPIO init to a common place - coreboot-gerrit

12 May 2019


      Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32759 )
Change subject: soc/intel/broadwell: Move GPIO init to a common place
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/32759/1/src/mainboard/google/auron/Makefile.... 
File src/mainboard/google/auron/Makefile.inc:
https://review.coreboot.org/#/c/32759/1/src/mainboard/google/auron/Makefile.... 
PS1, Line 36: romstage-y += variants/$(VARIANT_DIR)/gpio.c
Missing linebreak. (how did you do that?)
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/32759
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9309d2b842495f6cff33fdab18aa139a82c1959c
Gerrit-Change-Number: 32759
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 12 May 2019 12:55:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment