Change in coreboot[master]: mb/amd/mandolin: enable S0ix for mandolin - coreboot-gerrit

9 Feb 2021


      Attention is currently required from: Jason Glenesk, Raul Rangel, Martin Roth, Marshall Dawson, Mathew King, Karthik Ramasubramanian, Felix Held.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50198 )
Change subject: mb/amd/mandolin: enable S0ix for mandolin
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/amd/mandolin/variants/mandolin/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/50198/comment/208ebdf5_57bcf1ce 
PS1, Line 8: ACPI_FADT_HW_REDUCED_ACPI | ACPI_FADT_POWER_BUTTON
ACPI_FADT_LOW_PWR_IDLE_S0 makes sense. But, how is ACPI_FADT_HW_REDUCED_ACPI or ACPI_FADT_POWER_BUTTON related to S0ix?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/50198
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id03a8813cc42fa27b0f4131342c2cca4d9077ba4
Gerrit-Change-Number: 50198
Gerrit-PatchSet: 1
Gerrit-Owner: Jason Glenesk jason.glenesk@amd.corp-partner.google.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Mathew King mathewk@chromium.org
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Eric Peers epeers@google.com
Gerrit-Attention: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Martin Roth martinroth@google.com
Gerrit-Attention: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Attention: Mathew King mathewk@chromium.org
Gerrit-Attention: Jason Glenesk jason.glenesk@amd.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian kramasub@google.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 09 Feb 2021 07:03:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment