Change in coreboot[master]: amdfwtool: Set the region_type as 0 for entry "BIOS level 2" - coreboot-gerrit

1 Jun 2021


      Attention is currently required from: Raul Rangel, Marshall Dawson, Paul Menzel, Zheng Bao.
Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54871 )
Change subject: amdfwtool: Set the region_type as 0 for entry "BIOS level 2"
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/54871/comment/46a5a209_2a135ac8 
PS2, Line 9: But we need to set it explicitly as
           : a known value.
...
Or it's correcting an oversight first introduced in CB:33400, we're doing it for consistency, etc. […]
Done
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/54871
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8b914f9f02beecce707aba86248826cd9208e6c0
Gerrit-Change-Number: 54871
Gerrit-PatchSet: 3
Gerrit-Owner: Bao Zheng fishbaozi@gmail.com
Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Zheng Bao
Gerrit-Comment-Date: Tue, 01 Jun 2021 10:02:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Bao Zheng fishbaozi@gmail.com
Comment-In-Reply-To: Marshall Dawson marshalldawson3rd@gmail.com
Comment-In-Reply-To: Paul Menzel paulepanter@mailbox.org
Gerrit-MessageType: comment