Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39618 )
Change subject: util/lint/spelling.txt: Explain the commented-out entries ......................................................................
util/lint/spelling.txt: Explain the commented-out entries
If they were removed instead, it would be too easy to end up adding them back again. They are kept in a comment so that they can be tracked.
Also, explain why these two entries have been commented out.
Change-Id: I8225944b5e3d1e022af169dda33e0344d4c3bccd Signed-off-by: Angel Pons th3fanbus@gmail.com --- M util/lint/spelling.txt 1 file changed, 7 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/39618/1
diff --git a/util/lint/spelling.txt b/util/lint/spelling.txt index 1263144..58fe30d 100644 --- a/util/lint/spelling.txt +++ b/util/lint/spelling.txt @@ -7,10 +7,15 @@ # The format of each line is: # mistake||correction # -# Note that "sepc" and "acknowledgement" have been commented out. - +# Some entries may trigger false-positives, and have been commented out: +# +# Reason: Both spellings are correct. #acknowledgement||acknowledgment +# +# Reason: On RISC-V, `SEPC` is the name of a register. #sepc||spec +# + ACII||ASCII Debiab||Debian FTBS||FTBFS
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39618 )
Change subject: util/lint/spelling.txt: Explain the commented-out entries ......................................................................
Patch Set 1: Code-Review+2
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39618 )
Change subject: util/lint/spelling.txt: Explain the commented-out entries ......................................................................
util/lint/spelling.txt: Explain the commented-out entries
If they were removed instead, it would be too easy to end up adding them back again. They are kept in a comment so that they can be tracked.
Also, explain why these two entries have been commented out.
Change-Id: I8225944b5e3d1e022af169dda33e0344d4c3bccd Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/39618 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Felix Held felix-coreboot@felixheld.de --- M util/lint/spelling.txt 1 file changed, 7 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved
diff --git a/util/lint/spelling.txt b/util/lint/spelling.txt index 1263144..58fe30d 100644 --- a/util/lint/spelling.txt +++ b/util/lint/spelling.txt @@ -7,10 +7,15 @@ # The format of each line is: # mistake||correction # -# Note that "sepc" and "acknowledgement" have been commented out. - +# Some entries may trigger false-positives, and have been commented out: +# +# Reason: Both spellings are correct. #acknowledgement||acknowledgment +# +# Reason: On RISC-V, `SEPC` is the name of a register. #sepc||spec +# + ACII||ASCII Debiab||Debian FTBS||FTBFS
-
Angel Pons (Code Review) -
Felix Held (Code Review)