Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32079 )
Change subject: drivers/intel/fsp2_0: Use same stack with coreboot
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/32079/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/32079/3//COMMIT_MSG@9
PS3, Line 9: This patch ensures to have same stack base for FSP and coreboot.
:
: Feature added in FSP2.1
: - Remove stack swapping from FSP.
: - Stack will be shared between coreboot and FSP.
Isn't this CL actually correcting the stack base pointer passed into FSP rather than enabling the feature? I believe the feature was already enabled here CB:28358, just that the stack base pointer was set incorrectly?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32079
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I673b4216d991d8ccad725c3931006a694184106c
Gerrit-Change-Number: 32079
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 31 Mar 2019 17:57:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment