Kevin Chiu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44862 )
Change subject: mb/google/zork: update DRAM table for berknip ......................................................................
mb/google/zork: update DRAM table for berknip
Two DDR4 DRAM add ID9: CH2 DDR4 Hynix H5AN8G6NDJR-XNC 8Gb x 8 IDA: CH2 DDR4 Samsung K4AAG165WA-BCTD 16Gb x 8
BUG=b:165956925 BRANCH=zork TEST=emerge-zork coreboot
Change-Id: Ia21a561e9b89feeccb6509d9280eaf52cfc2f5a3 Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com --- M src/mainboard/google/zork/variants/berknip/spd/Makefile.inc 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/44862/1
diff --git a/src/mainboard/google/zork/variants/berknip/spd/Makefile.inc b/src/mainboard/google/zork/variants/berknip/spd/Makefile.inc index f53e662..16e982f 100644 --- a/src/mainboard/google/zork/variants/berknip/spd/Makefile.inc +++ b/src/mainboard/google/zork/variants/berknip/spd/Makefile.inc @@ -18,8 +18,8 @@ APCB_SOURCES += micron-MT40A1G16KD-062E-E_x2 # 0b0110 APCB_SOURCES += hynix-H5ANAG6NCMR-XNC_x2 # 0b0111 APCB_SOURCES += samsung-K4AAG165WA-BCWE_x2 # 0b1000 -APCB_SOURCES += empty # 0b1001 -APCB_SOURCES += empty # 0b1010 +APCB_SOURCES += hynix-H5AN8G6NDJR-XNC_x2 # 0b1001 +APCB_SOURCES += samsung-K4AAG165WA-BCTD_x2 # 0b1010 APCB_SOURCES += empty # 0b1011 APCB_SOURCES += empty # 0b1100 APCB_SOURCES += empty # 0b1101
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44862 )
Change subject: mb/google/zork: update DRAM table for berknip ......................................................................
Patch Set 1:
Please rebase this change on https://review.coreboot.org/c/coreboot/+/44871 and use spd_tools to generate the ids.
Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth, Rob Barnes, Aaron Durbin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44862
to look at the new patch set (#2).
Change subject: mb/google/zork: update DRAM table for berknip ......................................................................
mb/google/zork: update DRAM table for berknip
Two DDR4 DRAM add ID9: CH2 DDR4 Hynix H5AN8G6NDJR-XNC 8Gb x 8 IDA: CH2 DDR4 Samsung K4AAG165WA-BCTD 16Gb x 8
BUG=b:165956925 BRANCH=zork TEST=emerge-zork coreboot
Change-Id: Ia21a561e9b89feeccb6509d9280eaf52cfc2f5a3 Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com --- M src/mainboard/google/zork/variants/berknip/spd/Makefile.inc M src/mainboard/google/zork/variants/berknip/spd/dram_id.generated.txt M src/mainboard/google/zork/variants/berknip/spd/mem_parts_used.txt 3 files changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/44862/2
Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44862 )
Change subject: mb/google/zork: update DRAM table for berknip ......................................................................
Patch Set 2:
Patch Set 1:
Please rebase this change on https://review.coreboot.org/c/coreboot/+/44871 and use spd_tools to generate the ids.
Done
Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth, Rob Barnes, Aaron Durbin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44862
to look at the new patch set (#3).
Change subject: mb/google/zork: update DRAM table for berknip ......................................................................
mb/google/zork: update DRAM table for berknip
Two DDR4 DRAM add ID9: CH2 DDR4 Hynix H5AN8G6NDJR-XNC 8Gb x 8 IDA: CH2 DDR4 Samsung K4AAG165WA-BCTD 16Gb x 8
retore ID1/ID4 back which will still be used: ID1: CH2 DDR4 Samsung K4A8G165WC-BCWE 8Gb x 8 ID4: CH2 DDR4 Hynix H5ANAG6NCMR-VKC 16Gb x 8
BUG=b:165956925 BRANCH=zork TEST=1. gen part id by gen_part_id 2. emerge-zork coreboot
Change-Id: Ia21a561e9b89feeccb6509d9280eaf52cfc2f5a3 Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com --- M src/mainboard/google/zork/variants/berknip/spd/Makefile.inc M src/mainboard/google/zork/variants/berknip/spd/dram_id.generated.txt M src/mainboard/google/zork/variants/berknip/spd/mem_parts_used.txt 3 files changed, 12 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/44862/3
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44862 )
Change subject: mb/google/zork: update DRAM table for berknip ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44862/3/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/berknip/spd/mem_parts_used.txt:
PS3: Are these parts being added already used in some build? If not, then we should not assign fixed ID to the part.
Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth, Rob Barnes, Aaron Durbin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44862
to look at the new patch set (#4).
Change subject: mb/google/zork: update DRAM table for berknip ......................................................................
mb/google/zork: update DRAM table for berknip
Two DDR4 DRAM add ID9: CH2 DDR4 Hynix H5AN8G6NDJR-XNC 8Gb x 8 IDA: CH2 DDR4 Samsung K4AAG165WA-BCTD 16Gb x 8
BUG=b:165956925 BRANCH=zork TEST=1. gen part id by gen_part_id 2. emerge-zork coreboot
Change-Id: Ia21a561e9b89feeccb6509d9280eaf52cfc2f5a3 Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com --- M src/mainboard/google/zork/variants/berknip/spd/Makefile.inc M src/mainboard/google/zork/variants/berknip/spd/dram_id.generated.txt M src/mainboard/google/zork/variants/berknip/spd/mem_parts_used.txt 3 files changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/44862/4
Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44862 )
Change subject: mb/google/zork: update DRAM table for berknip ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44862/3/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/berknip/spd/mem_parts_used.txt:
PS3:
Are these parts being added already used in some build? If not, then we should not assign fixed ID t […]
Done
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44862 )
Change subject: mb/google/zork: update DRAM table for berknip ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44862/4/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/berknip/spd/mem_parts_used.txt:
https://review.coreboot.org/c/coreboot/+/44862/4/src/mainboard/google/zork/v... PS4, Line 8: 9 Why is this part being assigned ID 9? We should let the tool select the ID. Was this part already used in some build?
https://review.coreboot.org/c/coreboot/+/44862/4/src/mainboard/google/zork/v... PS4, Line 9: 10 Same here.
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44862 )
Change subject: mb/google/zork: update DRAM table for berknip ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44862/4/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/berknip/spd/mem_parts_used.txt:
https://review.coreboot.org/c/coreboot/+/44862/4/src/mainboard/google/zork/v... PS4, Line 8: 9
Why is this part being assigned ID 9? We should let the tool select the ID. […]
See "Tool 2 - gen_part_id.go" section of the spd_tools ddr4 README.md: https://source.chromium.org/chromiumos/chromiumos/codesearch/+/master:src/th...
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44862 )
Change subject: mb/google/zork: update DRAM table for berknip ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44862/4/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/berknip/spd/mem_parts_used.txt:
https://review.coreboot.org/c/coreboot/+/44862/4/src/mainboard/google/zork/v... PS4, Line 8: H5AN8G6NDJR-XNC I just noticed this. This part being added is exactly the same as the one on line #3. I believe the difference was originally to identify 1-channel v/s 2-channel. However, that is no longer needed as GPIO84 is used to determine this at runtime: https://source.chromium.org/chromiumos/chromiumos/codesearch/+/master:src/th...
Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth, Rob Barnes, Aaron Durbin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44862
to look at the new patch set (#5).
Change subject: mb/google/zork: update DRAM table for berknip ......................................................................
mb/google/zork: update DRAM table for berknip
Add Dual DDR4 Samsung K4AAG165WA-BCTD 16Gb x 8
BUG=b:165956925 BRANCH=zork TEST=1. gen part id by gen_part_id 2. emerge-zork coreboot
Change-Id: Ia21a561e9b89feeccb6509d9280eaf52cfc2f5a3 Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com --- M src/mainboard/google/zork/variants/berknip/spd/Makefile.inc M src/mainboard/google/zork/variants/berknip/spd/dram_id.generated.txt M src/mainboard/google/zork/variants/berknip/spd/mem_parts_used.txt 3 files changed, 3 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/44862/5
Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44862 )
Change subject: mb/google/zork: update DRAM table for berknip ......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/c/coreboot/+/44862/4/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/berknip/spd/mem_parts_used.txt:
https://review.coreboot.org/c/coreboot/+/44862/4/src/mainboard/google/zork/v... PS4, Line 8: H5AN8G6NDJR-XNC
I just noticed this. This part being added is exactly the same as the one on line #3. […]
Done
https://review.coreboot.org/c/coreboot/+/44862/4/src/mainboard/google/zork/v... PS4, Line 8: 9
See "Tool 2 - gen_part_id.go" section of the spd_tools ddr4 README.md: https://source.chromium. […]
Done
https://review.coreboot.org/c/coreboot/+/44862/4/src/mainboard/google/zork/v... PS4, Line 9: 10
Same here.
Done
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44862 )
Change subject: mb/google/zork: update DRAM table for berknip ......................................................................
Patch Set 5: Code-Review+2
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44862 )
Change subject: mb/google/zork: update DRAM table for berknip ......................................................................
Patch Set 5: Code-Review+1
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44862 )
Change subject: mb/google/zork: update DRAM table for berknip ......................................................................
Patch Set 5: Code-Review+2
Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44862 )
Change subject: mb/google/zork: update DRAM table for berknip ......................................................................
Patch Set 5:
hi reviewers, could you please help merge this one? thank you!
Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44862 )
Change subject: mb/google/zork: update DRAM table for berknip ......................................................................
mb/google/zork: update DRAM table for berknip
Add Dual DDR4 Samsung K4AAG165WA-BCTD 16Gb x 8
BUG=b:165956925 BRANCH=zork TEST=1. gen part id by gen_part_id 2. emerge-zork coreboot
Change-Id: Ia21a561e9b89feeccb6509d9280eaf52cfc2f5a3 Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/44862 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Aaron Durbin adurbin@chromium.org Reviewed-by: Rob Barnes robbarnes@google.com Reviewed-by: Furquan Shaikh furquan@google.com --- M src/mainboard/google/zork/variants/berknip/spd/Makefile.inc M src/mainboard/google/zork/variants/berknip/spd/dram_id.generated.txt M src/mainboard/google/zork/variants/berknip/spd/mem_parts_used.txt 3 files changed, 3 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved Furquan Shaikh: Looks good to me, approved Rob Barnes: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/zork/variants/berknip/spd/Makefile.inc b/src/mainboard/google/zork/variants/berknip/spd/Makefile.inc index 83eebe1..1f871a9 100644 --- a/src/mainboard/google/zork/variants/berknip/spd/Makefile.inc +++ b/src/mainboard/google/zork/variants/berknip/spd/Makefile.inc @@ -3,7 +3,7 @@
SPD_SOURCES = SPD_SOURCES += ddr4-spd-3.hex # ID = 0(0b0000) Parts = K4A8G165WC-BCTD -SPD_SOURCES += ddr4-spd-empty.hex # ID = 1(0b0001) +SPD_SOURCES += ddr4-spd-8.hex # ID = 1(0b0001) Parts = K4AAG165WA-BCTD SPD_SOURCES += ddr4-spd-1.hex # ID = 2(0b0010) Parts = MT40A512M16TB-062E:J SPD_SOURCES += ddr4-spd-1.hex # ID = 3(0b0011) Parts = H5AN8G6NDJR-XNC SPD_SOURCES += ddr4-spd-empty.hex # ID = 4(0b0100) diff --git a/src/mainboard/google/zork/variants/berknip/spd/dram_id.generated.txt b/src/mainboard/google/zork/variants/berknip/spd/dram_id.generated.txt index 45af67b..2522cdb 100644 --- a/src/mainboard/google/zork/variants/berknip/spd/dram_id.generated.txt +++ b/src/mainboard/google/zork/variants/berknip/spd/dram_id.generated.txt @@ -6,3 +6,4 @@ MT40A1G16KD-062E:E 6 (0110) H5ANAG6NCMR-XNC 7 (0111) K4AAG165WA-BCWE 8 (1000) +K4AAG165WA-BCTD 1 (0001) diff --git a/src/mainboard/google/zork/variants/berknip/spd/mem_parts_used.txt b/src/mainboard/google/zork/variants/berknip/spd/mem_parts_used.txt index 69d65d2..8e50ea0fc 100644 --- a/src/mainboard/google/zork/variants/berknip/spd/mem_parts_used.txt +++ b/src/mainboard/google/zork/variants/berknip/spd/mem_parts_used.txt @@ -5,3 +5,4 @@ MT40A1G16KD-062E:E, 6 H5ANAG6NCMR-XNC, 7 K4AAG165WA-BCWE, 8 +K4AAG165WA-BCTD
-
Aaron Durbin (Code Review) -
Furquan Shaikh (Code Review)
-
Kevin Chiu (Code Review)
-
Rob Barnes (Code Review)