Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/28724 )
Change subject: lib/boot_device: Add API for write protect a region
......................................................................
Patch Set 16: Code-Review+1
(3 comments)
https://review.coreboot.org/#/c/28724/16/src/drivers/spi/boot_device_rw_nomm...
File src/drivers/spi/boot_device_rw_nommap.c:
https://review.coreboot.org/#/c/28724/16/src/drivers/spi/boot_device_rw_nomm...
PS16, Line 111:
alignment
https://review.coreboot.org/#/c/28724/16/src/drivers/spi/boot_device_rw_nomm...
PS16, Line 129: region_device_region(rd), 1,
replace 1 with true
https://review.coreboot.org/#/c/28724/16/src/include/boot_device.h
File src/include/boot_device.h:
https://review.coreboot.org/#/c/28724/16/src/include/boot_device.h@69
PS16, Line 69: enum bootdev_prot_type type);
alignment,
could be made const enum
--
To view, visit
https://review.coreboot.org/c/coreboot/+/28724
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4c9376e2c2c7a4852f13c65824c6cd64a1c6ac0a
Gerrit-Change-Number: 28724
Gerrit-PatchSet: 16
Gerrit-Owner: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Tue, 15 Jan 2019 07:43:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment