Attention is currently required from: Arthur Heymans, Christian Walter, Felix Held, Fred Reitberger, Jason Glenesk, Julius Werner, Jérémy Compostella, Krystian Hebel, Matt DeVillier, Michał Żygowski, Raul Rangel.
Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69162?usp=email )
Change subject: security/tpm: support compiling in multiple TPM drivers
......................................................................
Patch Set 37:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/69162/comment/e56ef959_68e05afe :
PS31, Line 14: Makefile.inc files were updated to replace `all-*` with romstage,
And here are 132 failures caused by including what's not being used: https://qa.coreboot. […]
Finally figured out where my scary-looking condition got it wrong and now CI passes without excluding TPM drivers from any stages.
File src/drivers/i2c/tpm/Makefile.mk:
https://review.coreboot.org/c/coreboot/+/69162/comment/d1e6a79d_51977160 :
PS31, Line 5: romstage-$(CONFIG_DRIVER_TIS_DEFAULT) += tis.c
: ramstage-$(CONFIG_DRIVER_TIS_DEFAULT) += tis.c
: verstage-$(CONFIG_DRIVER_TIS_DEFAULT) += tis.c
:
: romstage-$(CONFIG_TPM_ATMEL) += tis_atmel.c
: ramstage-$(CONFIG_TPM_ATMEL) += tis_atmel.c
: verstage-$(CONFIG_TPM_ATMEL) += tis_atmel.c
:
: ifeq ($(CONFIG_TPM_GOOGLE),y)
:
: romstage-y += cr50.c
: ramstage-y += cr50.c
: verstage-y += cr50.c
: else
:
: romstage-y += tpm.c
: ramstage-y += tpm.c
: verstage-y += tpm.c
:
So now these files will no longer be compiled for postcar, but postcar may want to measure the ramst […]
Changes to Makefiles were dropped.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69162?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I44c5a1d825afe414c2f5c2c90f4cfe41ba9bef5f
Gerrit-Change-Number: 69162
Gerrit-PatchSet: 37
Gerrit-Owner: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 09 Apr 2024 21:50:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michał Żygowski
michal.zygowski@3mdeb.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-MessageType: comment