Frank Chu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48497 )
Change subject: mb/google/volteer: Add GPIO to drobit support ......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/c/coreboot/+/48497/3/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/drobit/gpio.c:
https://review.coreboot.org/c/coreboot/+/48497/3/src/mainboard/google/voltee... PS3, Line 85: /* F11 : THC1_SPI2_CLK ==> FPMCU_BOOT1 */ : PAD_CFG_GPO(GPP_F11, 0, DEEP),
This pin is EN_PP3300_WWAN
Done
https://review.coreboot.org/c/coreboot/+/48497/3/src/mainboard/google/voltee... PS3, Line 118: /* S0 : SNDW0_CLK ==> SNDW0_HP_CLK */ : PAD_CFG_NF(GPP_S0, NONE, DEEP, NF1), : /* S1 : SNDW0_DATA ==> SNDW0_HP_DATA */ : PAD_CFG_NF(GPP_S1, NONE, DEEP, NF1), : /* S2 : SNDW1_CLK ==> SNDW1_SPKR_CLK */ : PAD_CFG_NF(GPP_S2, NONE, DEEP, NF1), : /* S3 : SNDW1_DATA ==> SNDW1_SPKR_DATA */ : PAD_CFG_NF(GPP_S3, NONE, DEEP, NF1),
Do you use soundwire? It looks like those pins weren't be used from the schematics.
Done
https://review.coreboot.org/c/coreboot/+/48497/3/src/mainboard/google/voltee... PS3, Line 136: early_gpio_table
Please add "PAD_CFG_GPO(GPP_A13, 0, DEEP)," to early_gpio_table, […]
Done
-
Frank Chu (Code Review)