Change in coreboot[master]: drivers/intel/dptf: Introduce new thermal control mechanism for pch d...

[Sumeet R Pawnikar (Code Review)]

Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Patrick Rudolph, Karthik Ramasubramanian.
Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57096 )

Change subject: drivers/intel/dptf: Introduce new thermal control mechanism for pch device
......................................................................

Patch Set 4:

(4 comments)

File src/drivers/intel/dptf/Kconfig:

https://review.coreboot.org/c/coreboot/+/57096/comment/e50390ef_83b365f4 
PS3, Line 12: 	help
> also: […]

Done

https://review.coreboot.org/c/coreboot/+/57096/comment/a2bb22a9_20db1289 
PS3, Line 13: tpch
> dptf

Ack

File src/drivers/intel/dptf/dptf.c:

https://review.coreboot.org/c/coreboot/+/57096/comment/f0738027_1d95204d 
PS3, Line 212: 	acpigen_write_package(0);
> A 0-element package? how odd... but I think you still need to end the package too, i.e.: […]

Ack

https://review.coreboot.org/c/coreboot/+/57096/comment/c7b6d299_14ddd020 
PS3, Line 220: {
             : 	acpigen_write_scope("\_SB");
             : 	acpigen_write_device("TPCH");
> Does the scope of this device matter? Can it just live under the DPTF device like all the others (ex […]

Ack