Change in ...coreboot[master]: soc/intel/fsp_broadwell_de: Move FSP_DEBUG_LEVEL option here
Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31300
Change subject: soc/intel/fsp_broadwell_de: Move FSP_DEBUG_LEVEL option here ......................................................................
soc/intel/fsp_broadwell_de: Move FSP_DEBUG_LEVEL option here
It is not mentioned in the FSP spec and doesn't seem to be implemented for any other FSP than the Broadwell-DE one.
Change-Id: I87c758204f1aabf13f47de19fd87c6e1ed67258e Signed-off-by: Nico Huber nico.h@gmx.de --- M src/drivers/intel/fsp1_0/Kconfig M src/soc/intel/fsp_broadwell_de/fsp/Kconfig M src/soc/intel/fsp_broadwell_de/fsp/chipset_fsp_util.c 3 files changed, 12 insertions(+), 12 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/31300/1
diff --git a/src/drivers/intel/fsp1_0/Kconfig b/src/drivers/intel/fsp1_0/Kconfig index b2338aa..4ce528f 100644 --- a/src/drivers/intel/fsp1_0/Kconfig +++ b/src/drivers/intel/fsp1_0/Kconfig @@ -34,17 +34,6 @@ hex default 0x4000
-config FSP_1_0_DEBUG_LEVEL - int "FSP debug level (0-3)" - default 0 - range 0 3 - help - Select the debug level, where: - 0: DISABLED - 1: MINIMUM - 2: NORMAL - 3: MAXIMUM - config FSP_HEADER_PATH string "Location of FSP headers" help diff --git a/src/soc/intel/fsp_broadwell_de/fsp/Kconfig b/src/soc/intel/fsp_broadwell_de/fsp/Kconfig index b4f4886..f958e71 100644 --- a/src/soc/intel/fsp_broadwell_de/fsp/Kconfig +++ b/src/soc/intel/fsp_broadwell_de/fsp/Kconfig @@ -127,3 +127,14 @@ default n help Enable EHCI controller 2 + +config FSP_DEBUG_LEVEL + int "FSP debug level (0-3)" + default 0 + range 0 3 + help + Select the debug level, where: + 0: DISABLED + 1: MINIMUM + 2: NORMAL + 3: MAXIMUM diff --git a/src/soc/intel/fsp_broadwell_de/fsp/chipset_fsp_util.c b/src/soc/intel/fsp_broadwell_de/fsp/chipset_fsp_util.c index ef6212e..b8ef6b1 100644 --- a/src/soc/intel/fsp_broadwell_de/fsp/chipset_fsp_util.c +++ b/src/soc/intel/fsp_broadwell_de/fsp/chipset_fsp_util.c @@ -69,7 +69,7 @@ if (!IS_ENABLED(CONFIG_CONSOLE_SERIAL)) UpdData->SerialPortType = 0;
- UpdData->DebugOutputLevel = CONFIG_FSP_1_0_DEBUG_LEVEL; + UpdData->DebugOutputLevel = CONFIG_FSP_DEBUG_LEVEL;
/* * Memory Down
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31300 )
Change subject: soc/intel/fsp_broadwell_de: Move FSP_DEBUG_LEVEL option here ......................................................................
soc/intel/fsp_broadwell_de: Move FSP_DEBUG_LEVEL option here
It is not mentioned in the FSP spec and doesn't seem to be implemented for any other FSP than the Broadwell-DE one.
Change-Id: I87c758204f1aabf13f47de19fd87c6e1ed67258e Signed-off-by: Nico Huber nico.h@gmx.de Reviewed-on: https://review.coreboot.org/c/31300 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Rudolph siro@das-labor.org --- M src/drivers/intel/fsp1_0/Kconfig M src/soc/intel/fsp_broadwell_de/fsp/Kconfig M src/soc/intel/fsp_broadwell_de/fsp/chipset_fsp_util.c 3 files changed, 12 insertions(+), 12 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Rudolph: Looks good to me, approved
diff --git a/src/drivers/intel/fsp1_0/Kconfig b/src/drivers/intel/fsp1_0/Kconfig index b2338aa..4ce528f 100644 --- a/src/drivers/intel/fsp1_0/Kconfig +++ b/src/drivers/intel/fsp1_0/Kconfig @@ -34,17 +34,6 @@ hex default 0x4000
-config FSP_1_0_DEBUG_LEVEL - int "FSP debug level (0-3)" - default 0 - range 0 3 - help - Select the debug level, where: - 0: DISABLED - 1: MINIMUM - 2: NORMAL - 3: MAXIMUM - config FSP_HEADER_PATH string "Location of FSP headers" help diff --git a/src/soc/intel/fsp_broadwell_de/fsp/Kconfig b/src/soc/intel/fsp_broadwell_de/fsp/Kconfig index b4f4886..f958e71 100644 --- a/src/soc/intel/fsp_broadwell_de/fsp/Kconfig +++ b/src/soc/intel/fsp_broadwell_de/fsp/Kconfig @@ -127,3 +127,14 @@ default n help Enable EHCI controller 2 + +config FSP_DEBUG_LEVEL + int "FSP debug level (0-3)" + default 0 + range 0 3 + help + Select the debug level, where: + 0: DISABLED + 1: MINIMUM + 2: NORMAL + 3: MAXIMUM diff --git a/src/soc/intel/fsp_broadwell_de/fsp/chipset_fsp_util.c b/src/soc/intel/fsp_broadwell_de/fsp/chipset_fsp_util.c index ef6212e..b8ef6b1 100644 --- a/src/soc/intel/fsp_broadwell_de/fsp/chipset_fsp_util.c +++ b/src/soc/intel/fsp_broadwell_de/fsp/chipset_fsp_util.c @@ -69,7 +69,7 @@ if (!IS_ENABLED(CONFIG_CONSOLE_SERIAL)) UpdData->SerialPortType = 0;
- UpdData->DebugOutputLevel = CONFIG_FSP_1_0_DEBUG_LEVEL; + UpdData->DebugOutputLevel = CONFIG_FSP_DEBUG_LEVEL;
/* * Memory Down
-
Nico Huber (Code Review) -
Patrick Georgi (Code Review)