Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47402 )
Change subject: [RFC] mb/siemens/mc_apl1: Deduplicate wait_for_legacy_dev()
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47402/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/47402/3//COMMIT_MSG@12
PS3, Line 12: TODO: Define a Kconfig symbol to control this?
Since this is baseboard specific there is no need for a separated Kconfig switch. We can distinguish on the variant switch. So you can remove this TODO here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47402
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4e35b58adc074831ccec433b8e014db0695b955e
Gerrit-Change-Number: 47402
Gerrit-PatchSet: 3
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: siemens-bot
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 24 Nov 2020 11:52:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment