Attention is currently required from: Joel Linn, Matt DeVillier.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81426?usp=email )
Change subject: superio/ite: Add special fan vectors and further options ......................................................................
Patch Set 4:
(1 comment)
File src/superio/ite/common/env_ctrl.c:
https://review.coreboot.org/c/coreboot/+/81426/comment/999e33f0_35966f45 : PS1, Line 369: #endif
just set the vector count to 2 regardless of the Kconfig enablement, unless it causes an issue elsew […]
I guess the original intention was to keep the configuration struct clean for chips that don't have this feature. Though, I agree wasting some space there might be better than overengineering it.
I would decide between these two options: * have a separate C file for the fan vector code (if that doesn't bring other downsides I'm missing), or * always have the struct entries.