Attention is currently required from: Julius Werner, Karthik Ramasubramanian, Shelley Chen.
Keith Short has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80308?usp=email )
Change subject: util/cbfstool: Fallback to linear search ......................................................................
Patch Set 2:
(1 comment)
File util/cbfstool/flashmap/fmap.c:
https://review.coreboot.org/c/coreboot/+/80308/comment/b4f81789_0d2efa02 : PS1, Line 108: 16
I think if you want to allow FMAPs to be found at a smaller alignment it would make more sense to re […]
My EC binary wasn't forcing alignment of FMAP and I ran into this.
The [flash_ec](http://cs/h/chromium/chromiumos/codesearch/+/main:src/platform/ec/util/flash...) script uses cbfstool to patch in the CBI information when we store CBI in the EC flash instead of an external EEPROM.
This change preserves the speed of the binary search, at the cost of a slower cbfstool on images without an FMAP. Do you know of the distribution of coreboot images with and without an FMAP?
-
Keith Short (Code Review)