Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31936 )
Change subject: [RFC] util/sconfig: Drop topology from early static tree ......................................................................
Patch Set 5:
(1 comment)
Patch Set 5: Code-Review+1
(1 comment)
As long as we don't identify devices by their full path, this makes absolute sense.
Why the Kconfig, though? I'm eager to find out what Jenkins has to say :)
We need topology in romstages as long as we use some derivative of pcidev_on_root() to find node configs. While I don't like it, some bootblocks seemed to require static devicetree too. I would like to exclude static.c from bootblock-y, smm-y and maybe postcar-y too.
Kconfig is introduced to allow make the change gradually.
https://review.coreboot.org/c/coreboot/+/31936/3/util/sconfig/main.c File util/sconfig/main.c:
https://review.coreboot.org/c/coreboot/+/31936/3/util/sconfig/main.c@803 PS3, Line 803: ops
I'm not sure where the journey goes, currently. Do we want to keep […]
CB:33921 possiby did this already. The 'simple device' functions (pci_read/write_config) are not the .ops discussed here.
-
Kyösti Mälkki (Code Review)