Attention is currently required from: Raul Rangel, Furquan Shaikh, Martin Roth, Mathew King. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52908 )
Change subject: mb/google/guybrush: Configure wake resource for WiFi ......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52908/comment/5500313c_5bad9738 PS1, Line 13: is added to SSDT.
Can you please try configuring the pad to `PAD_SCI` instead of `PAD_NF_SCI`.
Even with PAD_SCI, system was not waking up.
- Is the mapping of GPIO_2 to GEVENT_8 looks correct in the OS?
Looked at the SCI mapping and looks correct in the OS. Read the SCI mapping register for WAKE_L from the OS and the concerned event map is correct GEVENT_8
Is the GPE_EN bit set when going into suspend? (probably will have to use S3 for this so that you can dump the state just before suspending).
I checked the GPE_EN bit and observed that GEVENT_8 is not set/enabled Here are the GEVENTs enabled: 0x81400028 GEVENT_31 | GEVENT_24 | GEVENT_22 (Trackpad) | GEVENT_5 (FP) | GEVENT_3 (EC)
- Is GPE_STS bit set on resume?
GPE_STS bit is also not set. I tried to wake first using the WLAN events. Later when the system resumes due to other wake sources, I can see that the bit corresponding to GEVENT_8 status is not set.
- Is the behavior same in case of S3 and S0i3?
We could not match the behavior with S3 since it is not fully functional yet.
-
Karthik Ramasubramanian (Code Review)