Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40821 )
Change subject: soc/amc/common/block/smbus: Include acpimmio_map.h in sm.c ......................................................................
soc/amc/common/block/smbus: Include acpimmio_map.h in sm.c
sm.c requires acpimmio_map.h for ACPIMMIO_* macros. This change includes acpimmio_map.h in sm.c
Signed-off-by: Furquan Shaikh furquan@google.com Change-Id: Ia049254fa389a76bcf6538c0449229b4d856086e --- M src/soc/amd/common/block/smbus/sm.c 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/40821/1
diff --git a/src/soc/amd/common/block/smbus/sm.c b/src/soc/amd/common/block/smbus/sm.c index cef5bba..99b24ec 100644 --- a/src/soc/amd/common/block/smbus/sm.c +++ b/src/soc/amd/common/block/smbus/sm.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */ /* This file is part of the coreboot project. */
+#include <amdblocks/acpimmio_map.h> #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h>
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40821 )
Change subject: soc/amc/common/block/smbus: Include acpimmio_map.h in sm.c ......................................................................
Patch Set 1: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40821 )
Change subject: soc/amc/common/block/smbus: Include acpimmio_map.h in sm.c ......................................................................
Patch Set 1: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40821 )
Change subject: soc/amc/common/block/smbus: Include acpimmio_map.h in sm.c ......................................................................
Patch Set 1:
(1 comment)
Oopsie
https://review.coreboot.org/c/coreboot/+/40821/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40821/1//COMMIT_MSG@7 PS1, Line 7: amc amd
Hello build bot (Jenkins), Raul Rangel, Angel Pons, Aaron Durbin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40821
to look at the new patch set (#2).
Change subject: soc/amd/common/block/smbus: Include acpimmio_map.h in sm.c ......................................................................
soc/amd/common/block/smbus: Include acpimmio_map.h in sm.c
sm.c requires acpimmio_map.h for ACPIMMIO_* macros. This change includes acpimmio_map.h in sm.c
Signed-off-by: Furquan Shaikh furquan@google.com Change-Id: Ia049254fa389a76bcf6538c0449229b4d856086e --- M src/soc/amd/common/block/smbus/sm.c 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/40821/2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40821 )
Change subject: soc/amd/common/block/smbus: Include acpimmio_map.h in sm.c ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40821/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40821/1//COMMIT_MSG@7 PS1, Line 7: amc
amd
Done
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40821 )
Change subject: soc/amd/common/block/smbus: Include acpimmio_map.h in sm.c ......................................................................
Patch Set 2: Code-Review+2
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40821 )
Change subject: soc/amd/common/block/smbus: Include acpimmio_map.h in sm.c ......................................................................
Patch Set 2: Code-Review+2
Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40821 )
Change subject: soc/amd/common/block/smbus: Include acpimmio_map.h in sm.c ......................................................................
soc/amd/common/block/smbus: Include acpimmio_map.h in sm.c
sm.c requires acpimmio_map.h for ACPIMMIO_* macros. This change includes acpimmio_map.h in sm.c
Signed-off-by: Furquan Shaikh furquan@google.com Change-Id: Ia049254fa389a76bcf6538c0449229b4d856086e Reviewed-on: https://review.coreboot.org/c/coreboot/+/40821 Reviewed-by: Raul Rangel rrangel@chromium.org Reviewed-by: Aaron Durbin adurbin@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/amd/common/block/smbus/sm.c 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved Raul Rangel: Looks good to me, approved
diff --git a/src/soc/amd/common/block/smbus/sm.c b/src/soc/amd/common/block/smbus/sm.c index cef5bba..99b24ec 100644 --- a/src/soc/amd/common/block/smbus/sm.c +++ b/src/soc/amd/common/block/smbus/sm.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */ /* This file is part of the coreboot project. */
+#include <amdblocks/acpimmio_map.h> #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h>
-
Aaron Durbin (Code Review) -
Angel Pons (Code Review)
-
Furquan Shaikh (Code Review)
-
Raul Rangel (Code Review)