Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29301 )
Change subject: src: Use include <reset.h> when appropriate ......................................................................
Patch Set 14:
(3 comments)
https://review.coreboot.org/#/c/29301/14/src/mainboard/google/foster/pmic.c File src/mainboard/google/foster/pmic.c:
https://review.coreboot.org/#/c/29301/14/src/mainboard/google/foster/pmic.c@... PS14, Line 26: #include "reset.h" Same file as included above.
https://review.coreboot.org/#/c/29301/14/src/mainboard/google/smaug/pmic.c File src/mainboard/google/smaug/pmic.c:
https://review.coreboot.org/#/c/29301/14/src/mainboard/google/smaug/pmic.c@2... PS14, Line 26: #include "reset.h" same...
https://review.coreboot.org/#/c/29301/14/src/southbridge/nvidia/ck804/early_... File src/southbridge/nvidia/ck804/early_setup_car.c:
https://review.coreboot.org/#/c/29301/14/src/southbridge/nvidia/ck804/early_... PS14, Line 366: void do_board_reset(void); why?