Attention is currently required from: Alexander Couzens. Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60661 )
Change subject: ec/lenovo/h8/acpi: Replace LEqual(a,b) with ASL 2.0 syntax ......................................................................
ec/lenovo/h8/acpi: Replace LEqual(a,b) with ASL 2.0 syntax
Replace `LEqual(a, b)` with `a == b`.
Change-Id: I49a7ed2d57124746815478f3ead8a8f7c54d048a Signed-off-by: Felix Singer felixsinger@posteo.net --- M src/ec/lenovo/h8/acpi/ec.asl M src/ec/lenovo/h8/acpi/systemstatus.asl M src/ec/lenovo/h8/acpi/thermal.asl 3 files changed, 8 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/60661/1
diff --git a/src/ec/lenovo/h8/acpi/ec.asl b/src/ec/lenovo/h8/acpi/ec.asl index 18463a5..31ddc55 100644 --- a/src/ec/lenovo/h8/acpi/ec.asl +++ b/src/ec/lenovo/h8/acpi/ec.asl @@ -64,9 +64,9 @@ Method (_REG, 2, NotSerialized) { /* Wait for ERAM driver loaded */ - if (LEqual(Arg1, One)) { + if (Arg1 == 1) { /* Fill HKEY defaults on first boot */ - if (LEqual(^HKEY.INIT, Zero)) { + if (^HKEY.INIT == 0) { Store (BTEB, ^HKEY.WBDC) Store (WWEB, ^HKEY.WWAN) Store (One, ^HKEY.INIT) diff --git a/src/ec/lenovo/h8/acpi/systemstatus.asl b/src/ec/lenovo/h8/acpi/systemstatus.asl index a5793be..7598154 100644 --- a/src/ec/lenovo/h8/acpi/systemstatus.asl +++ b/src/ec/lenovo/h8/acpi/systemstatus.asl @@ -5,7 +5,7 @@ { Method(_SST, 1, NotSerialized) { - If (LEqual (Arg0, 0)) { + If (Arg0 == 0) { /* Indicator off */
/* power TLED off */ @@ -14,7 +14,7 @@ _SB.PCI0.LPCB.EC.TLED(0x07) }
- If (LEqual (Arg0, 1)) { + If (Arg0 == 1) { /* working state */
/* power TLED on */ @@ -23,7 +23,7 @@ _SB.PCI0.LPCB.EC.TLED(0x07) }
- If (LEqual (Arg0, 2)) { + If (Arg0 == 2) { /* waking state */
/* power LED on */ @@ -32,7 +32,7 @@ _SB.PCI0.LPCB.EC.TLED(0xc7) }
- If (LEqual (Arg0, 3)) { + If (Arg0 == 3) { /* sleep state */
/* power TLED pulsing */ diff --git a/src/ec/lenovo/h8/acpi/thermal.asl b/src/ec/lenovo/h8/acpi/thermal.asl index d8346a1..8244bbc7 100644 --- a/src/ec/lenovo/h8/acpi/thermal.asl +++ b/src/ec/lenovo/h8/acpi/thermal.asl @@ -73,7 +73,7 @@ Method(_TMP) { #if defined(EC_LENOVO_H8_ME_WORKAROUND) /* Avoid tripping alarm if ME isn't booted at all yet */ - If (!MEB1 && LEqual (_SB.PCI0.LPCB.EC.TMP0, 128)) { + If (!MEB1 && _SB.PCI0.LPCB.EC.TMP0 == 128) { Return (C2K(40)) } Store (1, MEB1) @@ -160,7 +160,7 @@ Method(_TMP) { #if defined(EC_LENOVO_H8_ME_WORKAROUND) /* Avoid tripping alarm if ME isn't booted at all yet */ - If (!MEB2 && LEqual (_SB.PCI0.LPCB.EC.TMP1, 128)) { + If (!MEB2 && _SB.PCI0.LPCB.EC.TMP1 == 128) { Return (C2K(40)) } Store (1, MEB2)