Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Rizwan Qureshi, Angel Pons, Patrick Rudolph. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55965 )
Change subject: cpu/intel/common: Create get_cache_info() function ......................................................................
Patch Set 1:
(2 comments)
File src/cpu/intel/common/common_init.c:
https://review.coreboot.org/c/coreboot/+/55965/comment/9fdc7005_73104cf6 PS1, Line 329: get_cache_info @Tim, do you think we can move this code into x86 common ? and make same logic as https://review.coreboot.org/plugins/gitiles/coreboot/+/refs/heads/master/src... to pass the correct leaf
https://review.coreboot.org/c/coreboot/+/55965/comment/45cb81d9_858cff78 PS1, Line 332: : const size_t assoc = CPUID_CACHE_WAYS_OF_ASSOC(res) + 1; : const size_t partitions = CPUID_CACHE_PHYS_LINE(res) + 1; : const size_t cache_line_size = CPUID_CACHE_COHER_LINE(res) + 1; : const size_t number_of_sets = CPUID_CACHE_NO_OF_SETS(res) + 1; : const size_t cache_size = assoc * partitions * cache_line_size * number_of_sets; : printk(BIOS_INFO, "Cache Information : "); : printk(BIOS_INFO, "assoc=%zd par=%zd line_size=%zd sets=%zd\n", : assoc, partitions, cache_line_size, number_of_sets); : printk(BIOS_INFO, "@@ cache_size 0x%lx bytes\n", cache_size);
looking a little closer, I'm not sure if we'd SMBIOS (generic x86 code) to depend on soc/intel/commo […]
thats good idea may be