Attention is currently required from: Jason Glenesk, Marshall Dawson, Felix Held. Raul Rangel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/52953 )
Change subject: soc/amd/common/espi: Don't set alert pin in espi_set_initial_config ......................................................................
soc/amd/common/espi: Don't set alert pin in espi_set_initial_config
The eSPI spec says that the Alert Mode defaults to in-band on reset. This change ensures the controller is in sync with the eSPI peripheral.
The configured alert mode is configured in espi_set_general_configuration.
BUG=b:187122344, b:186135022 TEST=Boot guybrush and make sure we don't get any eSPI errors.
Signed-off-by: Raul E Rangel rrangel@chromium.org Change-Id: Ib43e190d08d77ecfcd22ead2bf42e5de2202b555 --- M src/soc/amd/common/block/lpc/espi_util.c 1 file changed, 0 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/52953/1
diff --git a/src/soc/amd/common/block/lpc/espi_util.c b/src/soc/amd/common/block/lpc/espi_util.c index 9f077d2..dfd19d0 100644 --- a/src/soc/amd/common/block/lpc/espi_util.c +++ b/src/soc/amd/common/block/lpc/espi_util.c @@ -859,9 +859,6 @@ { uint32_t espi_initial_mode = ESPI_OP_FREQ_16_MHZ | ESPI_IO_MODE_SINGLE;
- if (mb_cfg->dedicated_alert_pin) - espi_initial_mode |= ESPI_ALERT_MODE; - espi_write32(ESPI_SLAVE0_CONFIG, espi_initial_mode); }