Kyösti Mälkki has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31679 )
Change subject: device/pci_ops: Drop parameter from pci_bus_default_ops() ......................................................................
device/pci_ops: Drop parameter from pci_bus_default_ops()
A default is a build-time static value, fallback. Return value does not depend of input parameter.
Change-Id: I43ae28f465fb46391519ec97a2a50891d458c46d Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/31679 Reviewed-by: Felix Held felix-coreboot@felixheld.de Reviewed-by: Aaron Durbin adurbin@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/arch/x86/pci_ops.c M src/device/pci_ops.c M src/device/pci_ops_mmconf.c M src/include/device/pci_ops.h 4 files changed, 4 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved Felix Held: Looks good to me, approved
diff --git a/src/arch/x86/pci_ops.c b/src/arch/x86/pci_ops.c index 82f9fd2..f30bffe 100644 --- a/src/arch/x86/pci_ops.c +++ b/src/arch/x86/pci_ops.c @@ -16,7 +16,7 @@ #include <device/device.h> #include <device/pci_ops.h>
-const struct pci_bus_operations *pci_bus_default_ops(struct device *dev) +const struct pci_bus_operations *pci_bus_default_ops(void) { return &pci_cf8_conf1; } diff --git a/src/device/pci_ops.c b/src/device/pci_ops.c index de0bf63..b7c8942 100644 --- a/src/device/pci_ops.c +++ b/src/device/pci_ops.c @@ -27,7 +27,7 @@ bops = bus->dev->ops->ops_pci_bus(dev); } if (!bops) - bops = pci_bus_default_ops(dev); + bops = pci_bus_default_ops(); return bops; }
diff --git a/src/device/pci_ops_mmconf.c b/src/device/pci_ops_mmconf.c index 8b7b574..0af8f8e 100644 --- a/src/device/pci_ops_mmconf.c +++ b/src/device/pci_ops_mmconf.c @@ -71,7 +71,7 @@ .write32 = pci_mmconf_write_config32, };
-const struct pci_bus_operations *pci_bus_default_ops(struct device *dev) +const struct pci_bus_operations *pci_bus_default_ops(void) { return &pci_ops_mmconf; } diff --git a/src/include/device/pci_ops.h b/src/include/device/pci_ops.h index 6bcb3e9..6971ce4 100644 --- a/src/include/device/pci_ops.h +++ b/src/include/device/pci_ops.h @@ -24,7 +24,7 @@ void pci_write_config8(struct device *dev, unsigned int where, u8 val); void pci_write_config16(struct device *dev, unsigned int where, u16 val); void pci_write_config32(struct device *dev, unsigned int where, u32 val); -const struct pci_bus_operations *pci_bus_default_ops(struct device *dev); +const struct pci_bus_operations *pci_bus_default_ops(void); #endif
#ifdef __SIMPLE_DEVICE__