Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32313
Change subject: smbios: Fix copy paste error ......................................................................
smbios: Fix copy paste error
As reported by Coverity Scan CID 1400679.
Change-Id: I526b78a0697b7eb3c3dc75974c3a3a714b3d343f Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/arch/x86/smbios.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/32313/1
diff --git a/src/arch/x86/smbios.c b/src/arch/x86/smbios.c index c565462..f40f107 100644 --- a/src/arch/x86/smbios.c +++ b/src/arch/x86/smbios.c @@ -650,7 +650,7 @@ t->max_cache_size |= SMBIOS_CACHE_SIZE_UNIT_1KB; t->max_cache_size2 |= SMBIOS_CACHE_SIZE2_UNIT_1KB; } else { - if (cache_size < (SMBIOS_CACHE_SIZE_MASK * 64 * KiB)) + if (max_cache_size < (SMBIOS_CACHE_SIZE_MASK * 64 * KiB)) t->max_cache_size = max_cache_size / (64 * KiB); else t->max_cache_size = SMBIOS_CACHE_SIZE_OVERFLOW;
Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32313 )
Change subject: smbios: Fix copy paste error ......................................................................
Patch Set 2: Code-Review+2
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32313 )
Change subject: smbios: Fix copy paste error ......................................................................
Patch Set 2: Code-Review+2
Patrick Rudolph has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32313 )
Change subject: smbios: Fix copy paste error ......................................................................
smbios: Fix copy paste error
As reported by Coverity Scan CID 1400679.
Change-Id: I526b78a0697b7eb3c3dc75974c3a3a714b3d343f Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/32313 Reviewed-by: Lijian Zhao lijian.zhao@intel.com Reviewed-by: HAOUAS Elyes ehaouas@noos.fr Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/arch/x86/smbios.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved Lijian Zhao: Looks good to me, approved
diff --git a/src/arch/x86/smbios.c b/src/arch/x86/smbios.c index d71c0d5..1aa5be9 100644 --- a/src/arch/x86/smbios.c +++ b/src/arch/x86/smbios.c @@ -656,7 +656,7 @@ t->max_cache_size |= SMBIOS_CACHE_SIZE_UNIT_1KB; t->max_cache_size2 |= SMBIOS_CACHE_SIZE2_UNIT_1KB; } else { - if (cache_size < (SMBIOS_CACHE_SIZE_MASK * 64 * KiB)) + if (max_cache_size < (SMBIOS_CACHE_SIZE_MASK * 64 * KiB)) t->max_cache_size = max_cache_size / (64 * KiB); else t->max_cache_size = SMBIOS_CACHE_SIZE_OVERFLOW;
-
HAOUAS Elyes (Code Review) -
Lijian Zhao (Code Review)
-
Patrick Rudolph (Code Review)