Attention is currently required from: Arthur Heymans, Felix Held, Martin L Roth, Patrick Rudolph, Paul Menzel.
Sergii Dmytruk has posted comments on this change by Sergii Dmytruk. ( https://review.coreboot.org/c/coreboot/+/83424?usp=email )
Change subject: drivers/smmstore: add ability to write to whole flash
......................................................................
Patch Set 6:
(1 comment)
File src/include/smmstore.h:
https://review.coreboot.org/c/coreboot/+/83424/comment/9ae3881a_c9a4d3b9?usp... :
PS6, Line 25: SMMSTORE_CMD_USE_FULL_FLASH
Is that an official name? Should it be `…ALLOW_ACCESS_TO_FULL_FLASH` or so?
Official in a sense that it comes from Mr.Chromebox' EDK? No, it doesn't have these changes.
Because this is both a command and a modifier, there will be a tradeoff when choosing a name. Mind that applying the modifier changes the base for flashing, so it's not just lifting size limit but changing interpretation of offset as well. Not sure if `ALLOW_ACCESS` captures that better.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83424?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7f3dbfa965b9dcbade8b2f06a5bd2ac1345c7972
Gerrit-Change-Number: 83424
Gerrit-PatchSet: 6
Gerrit-Owner: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Sat, 31 Aug 2024 12:56:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org