Attention is currently required from: Arthur Heymans, Felix Held, Martin L Roth, Patrick Rudolph, Paul Menzel.

View Change

1 comment:

• File src/include/smmstore.h:

  • Patch Set #6, Line 25: SMMSTORE_CMD_USE_FULL_FLASH

    Is that an official name? Should it be `…ALLOW_ACCESS_TO_FULL_FLASH` or so?

    Official in a sense that it comes from Mr.Chromebox' EDK? No, it doesn't have these changes.

    Because this is both a command and a modifier, there will be a tradeoff when choosing a name. Mind that applying the modifier changes the base for flashing, so it's not just lifting size limit but changing interpretation of offset as well. Not sure if `ALLOW_ACCESS` captures that better.

To view, visit change 83424. To unsubscribe, or for help writing mail filters, visit settings.