Attention is currently required from: Paul Menzel, Mario Scheithauer, Lean Sheng Tan.
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71229 )
Change subject: soc/intel/elkhartlake: Make SATA speed limit configurable
......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/elkhartlake/chip.h:
https://review.coreboot.org/c/coreboot/+/71229/comment/1394f89e_4a8c70dc
PS2, Line 108: SATA_DEFAULT = 0,
: SATA_GEN1,
: SATA_GEN2
Should you also list 'SATA_GEN3' for the completeness?
Since Gen 3 is the highest SATA speed grade it is not really a limit then. In addition, inside FSP, Gen 3 is treated the same way default is. Therefore, I have not added Gen 3 to this list.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/71229
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I610263b34b0947378d2025211ece4a9ec8fbfef6
Gerrit-Change-Number: 71229
Gerrit-PatchSet: 2
Gerrit-Owner: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Comment-Date: Wed, 04 Jan 2023 11:28:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-MessageType: comment