Attention is currently required from: Ravi kumar, Shelley Chen, Martin Roth, Julius Werner. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49767 )
Change subject: sc7280: aop loading changes ......................................................................
Patch Set 35:
(26 comments)
File src/soc/qualcomm/sc7280/aop_load_reset.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119121): https://review.coreboot.org/c/coreboot/+/49767/comment/d14145af_9d0bccf5 PS35, Line 11: bool aop_fw_entry; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119121): https://review.coreboot.org/c/coreboot/+/49767/comment/553a7caf_d399b85a PS35, Line 11: bool aop_fw_entry; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119121): https://review.coreboot.org/c/coreboot/+/49767/comment/1695d981_8b601d51 PS35, Line 13: struct prog aop_fw_prog = code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119121): https://review.coreboot.org/c/coreboot/+/49767/comment/618694ff_f9640fa2 PS35, Line 13: struct prog aop_fw_prog = please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119121): https://review.coreboot.org/c/coreboot/+/49767/comment/6d3951dc_42f5cb14 PS35, Line 14: PROG_INIT(PROG_PAYLOAD, CONFIG_CBFS_PREFIX "/aop"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119121): https://review.coreboot.org/c/coreboot/+/49767/comment/b337fccd_8194e508 PS35, Line 14: PROG_INIT(PROG_PAYLOAD, CONFIG_CBFS_PREFIX "/aop"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119121): https://review.coreboot.org/c/coreboot/+/49767/comment/c66fc712_817de808 PS35, Line 16: if (prog_locate(&aop_fw_prog)) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119121): https://review.coreboot.org/c/coreboot/+/49767/comment/2cc49253_caa96f64 PS35, Line 16: if (prog_locate(&aop_fw_prog)) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119121): https://review.coreboot.org/c/coreboot/+/49767/comment/fecadd55_bac9eca8 PS35, Line 17: die("SOC image: AOP_FW not found"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119121): https://review.coreboot.org/c/coreboot/+/49767/comment/d83054d6_5f491908 PS35, Line 17: die("SOC image: AOP_FW not found"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119121): https://review.coreboot.org/c/coreboot/+/49767/comment/7714f812_8d92fa51 PS35, Line 19: aop_fw_entry = selfload(&aop_fw_prog); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119121): https://review.coreboot.org/c/coreboot/+/49767/comment/d618d656_a4cdfd50 PS35, Line 19: aop_fw_entry = selfload(&aop_fw_prog); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119121): https://review.coreboot.org/c/coreboot/+/49767/comment/5a2494ed_60863b86 PS35, Line 20: if (!aop_fw_entry) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119121): https://review.coreboot.org/c/coreboot/+/49767/comment/66041a1e_9085a312 PS35, Line 20: if (!aop_fw_entry) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119121): https://review.coreboot.org/c/coreboot/+/49767/comment/0f789cb3_61b2089d PS35, Line 21: die("SOC image: AOP load failed"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119121): https://review.coreboot.org/c/coreboot/+/49767/comment/e0ac7a66_be8b07a4 PS35, Line 21: die("SOC image: AOP load failed"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119121): https://review.coreboot.org/c/coreboot/+/49767/comment/207def54_445875b7 PS35, Line 23: clock_reset_aop(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119121): https://review.coreboot.org/c/coreboot/+/49767/comment/dfdc0941_bfea93d4 PS35, Line 23: clock_reset_aop(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119121): https://review.coreboot.org/c/coreboot/+/49767/comment/82d5796f_2f3daaba PS35, Line 25: printk(BIOS_DEBUG, "\nSOC:AOP brought out of reset.\n"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119121): https://review.coreboot.org/c/coreboot/+/49767/comment/82285eec_d5e833ff PS35, Line 25: printk(BIOS_DEBUG, "\nSOC:AOP brought out of reset.\n"); please, no spaces at the start of a line
File src/soc/qualcomm/sc7280/mmu.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119121): https://review.coreboot.org/c/coreboot/+/49767/comment/cc27fbe9_b411d1c1 PS35, Line 25: mmu_config_range((void *)_aop_code_ram, REGION_SIZE(aop_code_ram), CACHED_RAM); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119121): https://review.coreboot.org/c/coreboot/+/49767/comment/6714060c_5e20858a PS35, Line 25: mmu_config_range((void *)_aop_code_ram, REGION_SIZE(aop_code_ram), CACHED_RAM); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119121): https://review.coreboot.org/c/coreboot/+/49767/comment/1f8fc270_185f8f1b PS35, Line 26: mmu_config_range((void *)_aop_data_ram, REGION_SIZE(aop_data_ram), CACHED_RAM); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119121): https://review.coreboot.org/c/coreboot/+/49767/comment/ceda197d_d745985e PS35, Line 26: mmu_config_range((void *)_aop_data_ram, REGION_SIZE(aop_data_ram), CACHED_RAM); please, no spaces at the start of a line
File src/soc/qualcomm/sc7280/soc.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119121): https://review.coreboot.org/c/coreboot/+/49767/comment/a1115c88_043ed773 PS35, Line 15: REGION_SIZE(dram_aop) / KiB); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119121): https://review.coreboot.org/c/coreboot/+/49767/comment/20e25282_c9fe88a7 PS35, Line 15: REGION_SIZE(dram_aop) / KiB); please, no spaces at the start of a line
-
build bot (Jenkins) (Code Review)