Attention is currently required from: Tim Wawrzynczak, Patrick Rudolph.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55143 )
Change subject: soc/intel/alderlake: Set SaIpuEnable UPD from device state
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File src/soc/intel/alderlake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/55143/comment/27918fb3_14903df9
PS1, Line 214: m_cfg->SaIpuEnable
Yes, it could, but to me this is more maintainable, rather than relying on `dev` which was set 10+ l […]
You won't really be reusing `dev` here, but SaIpuEnable. I understand that it still leaves the door open for missing out the configuration if the code get re-ordered.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55143
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I53752f92c4b49093218cc34848727a72b63e84eb
Gerrit-Change-Number: 55143
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Wed, 02 Jun 2021 19:34:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment