Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/28975 )
Change subject: dynamic UART initialization for cavium cn8100 ......................................................................
Patch Set 1:
(4 comments)
Tested on hardware ?
https://review.coreboot.org/#/c/28975/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/28975/1//COMMIT_MSG@7 PS1, Line 7: dynamic UART initialization for cavium cn8100 Add prefix: soc/cavium:
https://review.coreboot.org/#/c/28975/1//COMMIT_MSG@8 PS1, Line 8: missing commit body
https://review.coreboot.org/#/c/28975/1/src/soc/cavium/cn81xx/soc.c File src/soc/cavium/cn81xx/soc.c:
https://review.coreboot.org/#/c/28975/1/src/soc/cavium/cn81xx/soc.c@395 PS1, Line 395: struct device *child; struct device *dev;
https://review.coreboot.org/#/c/28975/1/src/soc/cavium/cn81xx/soc.c@397 PS1, Line 397: child = dev_find_slot(1, PCI_DEVFN(8, i)); Add comment: using device enable state from devicetree.cb ?