Attention is currently required from: Andrey Petrov, Kapil Porwal, Nick Vaccaro, Subrata Banik.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76921?usp=email )
Change subject: drivers/intel/fsp2_0: Add API to convert BMP images to GOP BLT buffer ......................................................................
Patch Set 4:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/76921/comment/eedcdc72_583994db : PS3, Line 18: It also adds a : new config (BMP_LOGO_TO_GOP_BLT) to ensure backward compatibility with : older generation FSP.
UPDs are different between just passing BMP image to FSP vs GOP BLT to FSP.
Can this be better modeled?
Are you saying pass the GOP BLT by default (if BMP_LOGO is enabled)?
Almost. I mean, always built in the driver, but still run-time detect if BMP or BLT should be passed.
File src/drivers/intel/fsp2_0/fsp_gop_blt.c:
PS3:
Maybe the same structs could be used for coreboot in general, and then only the structs are conver […]
I meant just a lot of the helper functions introduced here.
Also, will “AMD FSP” ever use this?