[M] Change in coreboot[main]: device: Add support for multiple PCI segment groups - coreboot-gerrit

12 Jan 2024


      Attention is currently required from: Cliff Huang, Fred Reitberger, Jason Glenesk, Lance Zhao, Matt DeVillier, Nico Huber, Patrick Rudolph, Tim Wawrzynczak.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79927?usp=email )
Change subject: device: Add support for multiple PCI segment groups
......................................................................
Patch Set 4:
(1 comment)
File src/include/device/pci_def.h:
https://review.coreboot.org/c/coreboot/+/79927/comment/33be57f2_bbe590de :
PS4, Line 595: #define PCI_SEGMENT_GROUP_COUNT		((CONFIG_ECAM_MMCONF_BUS_NUMBER >> 8) + 1)
this might be an off by one bug for CONFIG_ECAM_MMCONF_BUS_NUMBER == 256
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/79927?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ied3313c41896362dd989ee2ab1b1bcdced840aa8
Gerrit-Change-Number: 79927
Gerrit-PatchSet: 4
Gerrit-Owner: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Cliff Huang cliff.huang@intel.com
Gerrit-Reviewer: Fred Reitberger reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Reviewer: Lance Zhao lance.zhao@gmail.com
Gerrit-Reviewer: Matt DeVillier matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Tim Wawrzynczak inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Lance Zhao lance.zhao@gmail.com
Gerrit-Attention: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Cliff Huang cliff.huang@intel.com
Gerrit-Attention: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Attention: Matt DeVillier matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Tim Wawrzynczak inforichland@gmail.com
Gerrit-Attention: Fred Reitberger reitbergerfred@gmail.com
Gerrit-Comment-Date: Fri, 12 Jan 2024 16:29:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment