Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40308 )
Change subject: mb/ocp/tiogapass: Override SMBIOS data
......................................................................
Patch Set 14:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40308/14/src/mainboard/ocp/tiogapas...
File src/mainboard/ocp/tiogapass/ramstage.c:
https://review.coreboot.org/c/coreboot/+/40308/14/src/mainboard/ocp/tiogapas...
PS14, Line 33: const char *smbios_system_manufacturer(void)
I think we should move this code to src/vendorcode/ocp […]
vendorcode is for code that shouldn't be modified because there's a canonical source for it somewhere else. Yes, we didn't really follow up on that split, but please let's try not to make it worse :-)
How about src/drivers/ocp/dmi, analogous to src/drivers/secunet/dmi?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40308
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I08c958dfad83216cd12545760a19d205efc2515b
Gerrit-Change-Number: 40308
Gerrit-PatchSet: 14
Gerrit-Owner: Johnny Lin
Gerrit-Reviewer: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jingle Hsu
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Morgan Jang
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 20 Apr 2020 16:28:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-MessageType: comment