Jamie Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38237 )
Change subject: mb/google/hatch: Remove fixed IccMax values ......................................................................
mb/google/hatch: Remove fixed IccMax values
Remove fixed IccMax values for all domains. IccMax will be selected by CPU SKU in vr_config.
BUG=b:145094963 BRANCH=None TEST=build coreboot and fsp with enabled fw_debug. Flashed to device and checked the log.
Signed-off-by: Jamie Chen jamie.chen@intel.com Change-Id: I3f623d143f66c4f6ec63705844c9be7173feeb52 --- M src/mainboard/google/hatch/variants/baseboard/devicetree.cb 1 file changed, 7 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/38237/1
diff --git a/src/mainboard/google/hatch/variants/baseboard/devicetree.cb b/src/mainboard/google/hatch/variants/baseboard/devicetree.cb index d944dcd..b4d7afd 100644 --- a/src/mainboard/google/hatch/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/hatch/variants/baseboard/devicetree.cb @@ -58,6 +58,9 @@
register "PmTimerDisabled" = "1"
+ # Select CPU PL2/PL4 config + register "cpu_pl2_4_cfg" = "baseline" + # VR Settings Configuration for 4 Domains #+----------------+-------+-------+-------+-------+ #| Domain/Setting | SA | IA | GTUS | GTS | @@ -83,7 +86,7 @@ .psi4enable = 1, .imon_slope = 0x0, .imon_offset = 0x0, - .icc_max = VR_CFG_AMP(6), + .icc_max = 0, .voltage_limit = 1520, .ac_loadline = 1030, .dc_loadline = 1030, @@ -98,7 +101,7 @@ .psi4enable = 1, .imon_slope = 0x0, .imon_offset = 0x0, - .icc_max = VR_CFG_AMP(70), + .icc_max = 0, .voltage_limit = 1520, .ac_loadline = 180, .dc_loadline = 180, @@ -113,7 +116,7 @@ .psi4enable = 1, .imon_slope = 0x0, .imon_offset = 0x0, - .icc_max = VR_CFG_AMP(31), + .icc_max = 0, .voltage_limit = 1520, .ac_loadline = 310, .dc_loadline = 310, @@ -128,7 +131,7 @@ .psi4enable = 1, .imon_slope = 0x0, .imon_offset = 0x0, - .icc_max = VR_CFG_AMP(31), + .icc_max = 0, .voltage_limit = 1520, .ac_loadline = 310, .dc_loadline = 310,
Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38237 )
Change subject: mb/google/hatch: Remove fixed IccMax values ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38237/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38237/1//COMMIT_MSG@10 PS1, Line 10: vr_config. in fill_vr_domain_config function.
Hello Subrata Banik, Kane Chen, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38237
to look at the new patch set (#2).
Change subject: mb/google/hatch: Remove fixed IccMax values ......................................................................
mb/google/hatch: Remove fixed IccMax values
Remove fixed IccMax values for all domains. IccMax will be selected by CPU SKU in fill_vr_config function.
BUG=b:145094963 BRANCH=None TEST=build coreboot and fsp with enabled fw_debug. Flashed to device and checked the log.
Signed-off-by: Jamie Chen jamie.chen@intel.com Change-Id: I3f623d143f66c4f6ec63705844c9be7173feeb52 --- M src/mainboard/google/hatch/variants/baseboard/devicetree.cb 1 file changed, 7 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/38237/2
Hello Subrata Banik, Kane Chen, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38237
to look at the new patch set (#3).
Change subject: mb/google/hatch: Remove fixed IccMax values ......................................................................
mb/google/hatch: Remove fixed IccMax values
Remove fixed IccMax values for all domains. IccMax will be selected by CPU SKU in fill_vr_domain_config function.
BUG=b:145094963 BRANCH=None TEST=build coreboot and fsp with enabled fw_debug. Flashed to device and checked the log.
Signed-off-by: Jamie Chen jamie.chen@intel.com Change-Id: I3f623d143f66c4f6ec63705844c9be7173feeb52 --- M src/mainboard/google/hatch/variants/baseboard/devicetree.cb 1 file changed, 7 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/38237/3
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38237 )
Change subject: mb/google/hatch: Remove fixed IccMax values ......................................................................
Patch Set 3: Code-Review+2
Jamie Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38237 )
Change subject: mb/google/hatch: Remove fixed IccMax values ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38237/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38237/1//COMMIT_MSG@10 PS1, Line 10: vr_config.
in fill_vr_domain_config function.
Done
Edward Hill has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38237 )
Change subject: mb/google/hatch: Remove fixed IccMax values ......................................................................
Patch Set 4: Code-Review+2
Edward O'Callaghan has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38237 )
Change subject: mb/google/hatch: Remove fixed IccMax values ......................................................................
mb/google/hatch: Remove fixed IccMax values
Remove fixed IccMax values for all domains. IccMax will be selected by CPU SKU in fill_vr_domain_config function.
BUG=b:145094963 BRANCH=None TEST=build coreboot and fsp with enabled fw_debug. Flashed to device and checked the log.
Signed-off-by: Jamie Chen jamie.chen@intel.com Change-Id: I3f623d143f66c4f6ec63705844c9be7173feeb52 Reviewed-on: https://review.coreboot.org/c/coreboot/+/38237 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Edward Hill ecgh@chromium.org Reviewed-by: Edward O'Callaghan quasisec@chromium.org --- M src/mainboard/google/hatch/variants/baseboard/devicetree.cb 1 file changed, 7 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Edward Hill: Looks good to me, approved Edward O'Callaghan: Looks good to me, approved
diff --git a/src/mainboard/google/hatch/variants/baseboard/devicetree.cb b/src/mainboard/google/hatch/variants/baseboard/devicetree.cb index d944dcd..b4d7afd 100644 --- a/src/mainboard/google/hatch/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/hatch/variants/baseboard/devicetree.cb @@ -58,6 +58,9 @@
register "PmTimerDisabled" = "1"
+ # Select CPU PL2/PL4 config + register "cpu_pl2_4_cfg" = "baseline" + # VR Settings Configuration for 4 Domains #+----------------+-------+-------+-------+-------+ #| Domain/Setting | SA | IA | GTUS | GTS | @@ -83,7 +86,7 @@ .psi4enable = 1, .imon_slope = 0x0, .imon_offset = 0x0, - .icc_max = VR_CFG_AMP(6), + .icc_max = 0, .voltage_limit = 1520, .ac_loadline = 1030, .dc_loadline = 1030, @@ -98,7 +101,7 @@ .psi4enable = 1, .imon_slope = 0x0, .imon_offset = 0x0, - .icc_max = VR_CFG_AMP(70), + .icc_max = 0, .voltage_limit = 1520, .ac_loadline = 180, .dc_loadline = 180, @@ -113,7 +116,7 @@ .psi4enable = 1, .imon_slope = 0x0, .imon_offset = 0x0, - .icc_max = VR_CFG_AMP(31), + .icc_max = 0, .voltage_limit = 1520, .ac_loadline = 310, .dc_loadline = 310, @@ -128,7 +131,7 @@ .psi4enable = 1, .imon_slope = 0x0, .imon_offset = 0x0, - .icc_max = VR_CFG_AMP(31), + .icc_max = 0, .voltage_limit = 1520, .ac_loadline = 310, .dc_loadline = 310,
-
Edward Hill (Code Review) -
Edward O'Callaghan (Code Review)
-
Jamie Chen (Code Review)
-
Kane Chen (Code Review)