Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/74150 )
Change subject: Makefile.inc: introduce all_x86 target ......................................................................
Makefile.inc: introduce all_x86 target
For compilation units that should be built for all stages that run on the x86 cores in a newer AMD SoC, but can't be built for verstage on PSP which is an ARM core, the 'all' target can't be used, since that would result in the compilation unit also being added to the verstage target in the verstage on PSP case. In order to not need to add a compilation unit to the 'bootblock', 'verstage_x86', 'romstage', and 'ramstage' targets in separate lines in the Makefile, introduce the 'all_x86' target that adds a file to 'bootblock', 'verstage_x86', 'romstage', 'postcar', and 'ramstage'. The compilation units also need to be added to the 'postcar' stage which is only present on the pre-Zen SoCs to be able to also use the 'all_x86' target in common AMD code that is also used in those pre-Zen SoCs.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: I9d0184182b931185990094d0874b49c0b5cb9f7e Reviewed-on: https://review.coreboot.org/c/coreboot/+/74150 Reviewed-by: Fred Reitberger reitbergerfred@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Matt DeVillier matt.devillier@amd.corp-partner.google.com Reviewed-by: Arthur Heymans arthur@aheymans.xyz --- M Makefile.inc 1 file changed, 31 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved Fred Reitberger: Looks good to me, approved Matt DeVillier: Looks good to me, approved
diff --git a/Makefile.inc b/Makefile.inc index d2d3f88..6901ef4 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -107,6 +107,9 @@ $(call add-special-class,all) all-handler = $(foreach class,bootblock verstage romstage postcar ramstage,$(eval $(class)-y += $(2)))
+$(call add-special-class,all_x86) +all_x86-handler = $(foreach class,bootblock verstage_x86 romstage postcar ramstage,$(eval $(class)-y += $(2))) + $(call add-special-class,verstage_x86) ifeq ($(CONFIG_ARCH_VERSTAGE_X86_32)$(CONFIG_ARCH_VERSTAGE_X86_64),y) verstage_x86-handler = $(eval verstage-y += $(2))