HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40314 )
Change subject: nb/i945: Display a message when dual Channel may be used ......................................................................
nb/i945: Display a message when dual Channel may be used
Add INFO message, if dual channel operation is supported, but the boad is populated in Single mode.
Change-Id: I3e794949d61715783036ad0471a2014ebc76adbf Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/northbridge/intel/i945/raminit.c 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/40314/1
diff --git a/src/northbridge/intel/i945/raminit.c b/src/northbridge/intel/i945/raminit.c index f26fac6..36a8f58 100644 --- a/src/northbridge/intel/i945/raminit.c +++ b/src/northbridge/intel/i945/raminit.c @@ -472,6 +472,10 @@ if (!dimm_mask) die("No memory installed.\n");
+ if (sdram_capabilities_dual_channel() && + (dimm_mask == 3 || dimm_mask == 0xc)) + printk(BIOS_INFO, "Dual Channel supported, but populated in Single mode!\m"); + if (!(dimm_mask & ((1 << DIMM_SOCKETS) - 1))) /* FIXME: Possibly does not boot in this case */ printk(BIOS_INFO, "Channel 0 has no memory populated.\n");
Hello build bot (Jenkins), Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40314
to look at the new patch set (#2).
Change subject: nb/i945: Display a message when dual Channel may be used ......................................................................
nb/i945: Display a message when dual Channel may be used
Add INFO message, if dual channel operation is supported, but the boad is populated in Single mode.
Change-Id: I3e794949d61715783036ad0471a2014ebc76adbf Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/northbridge/intel/i945/raminit.c 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/40314/2
Hello build bot (Jenkins), Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40314
to look at the new patch set (#3).
Change subject: nb/i945(GC): Display a message when dual Channel may be used ......................................................................
nb/i945(GC): Display a message when dual Channel may be used
Add INFO message, if dual channel operation is supported, but the boad is populated in Single mode.
Change-Id: I3e794949d61715783036ad0471a2014ebc76adbf Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/northbridge/intel/i945/raminit_i945gc.c 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/40314/3
Hello build bot (Jenkins), Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40314
to look at the new patch set (#4).
Change subject: nb/i945(GC): Display a message when dual channel may be used ......................................................................
nb/i945(GC): Display a message when dual channel may be used
Add INFO message, if dual channel operation is supported, but the boad is populated in Single mode.
Change-Id: I3e794949d61715783036ad0471a2014ebc76adbf Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/northbridge/intel/i945/raminit_i945gc.c 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/40314/4
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/40314 )
Change subject: nb/i945(GC): Display a message when dual channel may be used ......................................................................
Abandoned
-
HAOUAS Elyes (Code Review)