Change in coreboot[master]: mb/razer/blade_stealth_kbl/dsdt.asl: Use macros

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

HAOUAS Elyes (Code Review)

19 Sep 2020 19 Sep '20

11:33 a.m.

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45548 )

Change subject: mb/razer/blade_stealth_kbl/dsdt.asl: Use macros ......................................................................

mb/razer/blade_stealth_kbl/dsdt.asl: Use macros

Use defined macros. Also, correct the DSDT revision.

Change-Id: I65aeeefeb1f144dad8826bfbe021d769df9a7135 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/razer/blade_stealth_kbl/dsdt.asl 1 file changed, 3 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/45548/1

diff --git a/src/mainboard/razer/blade_stealth_kbl/dsdt.asl b/src/mainboard/razer/blade_stealth_kbl/dsdt.asl index ec3ca79..66e7c0c 100644 --- a/src/mainboard/razer/blade_stealth_kbl/dsdt.asl +++ b/src/mainboard/razer/blade_stealth_kbl/dsdt.asl @@ -5,9 +5,9 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x05, // DSDT revision: ACPI v5.0 - "COREv4", // OEM id - "COREBOOT", // OEM table id + 0x02, // DSDT revision: ACPI v2.0 and greater + OEM_ID, + ACPI_TABLE_CREATOR, 0x20110725 // OEM revision ){ //Platform

Attachments:

attachment.htm (text/html — 2.7 KB)

Show replies by date

HAOUAS Elyes (Code Review)

26 Sep 26 Sep

11:55 a.m.

New subject: Change in coreboot[master]: mb/{51nb/x210,razer/blade_stealth_kbl}/dsdt.asl: Use macros

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45548

to look at the new patch set (#2).

Change subject: mb/{51nb/x210,razer/blade_stealth_kbl}/dsdt.asl: Use macros ......................................................................

mb/{51nb/x210,razer/blade_stealth_kbl}/dsdt.asl: Use macros

Use defined macros. Also, correct the DSDT revision.

Change-Id: I65aeeefeb1f144dad8826bfbe021d769df9a7135 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/51nb/x210/dsdt.asl M src/mainboard/razer/blade_stealth_kbl/dsdt.asl 2 files changed, 4 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/45548/2

Paul Menzel (Code Review)

2:30 p.m.

New subject: Change in coreboot[master]: mb/{51nb/x210,razer/blade_stealth_kbl}/dsdt.asl: Use macros

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45548 )

Change subject: mb/{51nb/x210,razer/blade_stealth_kbl}/dsdt.asl: Use macros ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45548/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/45548/2//COMMIT_MSG@10 PS2, Line 10: Also, correct the DSDT revision. Please make it two commits, and note, that the ACPI DSDT revision decrease from 0x5 to 0x2.

-- To view, visit https://review.coreboot.org/c/coreboot/+/45548 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I65aeeefeb1f144dad8826bfbe021d769df9a7135 Gerrit-Change-Number: 45548 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sat, 26 Sep 2020 12:30:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

28 Sep 28 Sep

10 a.m.

New subject: Change in coreboot[master]: mb/{51nb/x210,razer/blade_stealth_kbl}/dsdt.asl: Use macros

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45548 )

Change subject: mb/{51nb/x210,razer/blade_stealth_kbl}/dsdt.asl: Use macros ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45548/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/45548/2//COMMIT_MSG@10 PS2, Line 10: Also, correct the DSDT revision.

...

Please make it two commits, and note, that the ACPI DSDT revision decrease from 0x5 to 0x2.

Thx

-- To view, visit https://review.coreboot.org/c/coreboot/+/45548 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I65aeeefeb1f144dad8826bfbe021d769df9a7135 Gerrit-Change-Number: 45548 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 28 Sep 2020 08:00:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

10 a.m.

New subject: Change in coreboot[master]: mb/{51nb/x210,razer/blade_stealth_kbl}/dsdt.asl: Use macros

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45548

to look at the new patch set (#3).

Change subject: mb/{51nb/x210,razer/blade_stealth_kbl}/dsdt.asl: Use macros ......................................................................

mb/{51nb/x210,razer/blade_stealth_kbl}/dsdt.asl: Use macros

Use defined macros.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/45548/3

HAOUAS Elyes (Code Review)

1 Oct 1 Oct

2:27 p.m.

New subject: Change in coreboot[master]: mb/{51nb/x210,razer/blade_stealth_kbl}/dsdt.asl: Use macros

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45548

to look at the new patch set (#4).

Change subject: mb/{51nb/x210,razer/blade_stealth_kbl}/dsdt.asl: Use macros ......................................................................

mb/{51nb/x210,razer/blade_stealth_kbl}/dsdt.asl: Use macros

Use defined macros.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/45548/4

HAOUAS Elyes (Code Review)

2:54 p.m.

New subject: Change in coreboot[master]: mb/{51nb/x210,razer/blade_stealth_kbl}/dsdt.asl: Use macros

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45548

to look at the new patch set (#5).

Change subject: mb/{51nb/x210,razer/blade_stealth_kbl}/dsdt.asl: Use macros ......................................................................

mb/{51nb/x210,razer/blade_stealth_kbl}/dsdt.asl: Use macros

Use defined macros.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/45548/5

Werner Zeh (Code Review)

3:58 p.m.

New subject: Change in coreboot[master]: mb/{51nb/x210,razer/blade_stealth_kbl}/dsdt.asl: Use macros

Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45548 )

Change subject: mb/{51nb/x210,razer/blade_stealth_kbl}/dsdt.asl: Use macros ......................................................................

Patch Set 6: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/45548/6//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/45548/6//COMMIT_MSG@9 PS6, Line 9: Use defined macros. Add "for DSDT revision" to make things more clear?

-- To view, visit https://review.coreboot.org/c/coreboot/+/45548 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I65aeeefeb1f144dad8826bfbe021d769df9a7135 Gerrit-Change-Number: 45548 Gerrit-PatchSet: 6 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Werner Zeh werner.zeh@siemens.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 01 Oct 2020 13:58:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

9:04 p.m.

New subject: Change in coreboot[master]: mb/{51nb/x210,razer/blade_stealth_kbl}/dsdt.asl: Use macros

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45548 )

Change subject: mb/{51nb/x210,razer/blade_stealth_kbl}/dsdt.asl: Use macros ......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45548/6//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/45548/6//COMMIT_MSG@9 PS6, Line 9: Use defined macros.

...

Add "for DSDT revision" to make things more clear?

Thx

-- To view, visit https://review.coreboot.org/c/coreboot/+/45548 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I65aeeefeb1f144dad8826bfbe021d769df9a7135 Gerrit-Change-Number: 45548 Gerrit-PatchSet: 6 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Werner Zeh werner.zeh@siemens.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 01 Oct 2020 19:04:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Werner Zeh werner.zeh@siemens.com Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

9:04 p.m.

New subject: Change in coreboot[master]: mb/{51nb/x210,razer/blade_stealth_kbl}/dsdt.asl: Use macros

Hello build bot (Jenkins), Nico Huber, Werner Zeh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45548

to look at the new patch set (#7).

Change subject: mb/{51nb/x210,razer/blade_stealth_kbl}/dsdt.asl: Use macros ......................................................................

mb/{51nb/x210,razer/blade_stealth_kbl}/dsdt.asl: Use macros

Use defined macros for DSDT revision.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/45548/7

-- To view, visit https://review.coreboot.org/c/coreboot/+/45548 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I65aeeefeb1f144dad8826bfbe021d769df9a7135 Gerrit-Change-Number: 45548 Gerrit-PatchSet: 7 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Werner Zeh werner.zeh@siemens.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

HAOUAS Elyes (Code Review)

5 Oct 5 Oct

5:23 p.m.

New subject: Change in coreboot[master]: mb/{51nb/x210,razer/blade_stealth_kbl}/dsdt.asl: Use macros

HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/45548 )

Change subject: mb/{51nb/x210,razer/blade_stealth_kbl}/dsdt.asl: Use macros ......................................................................

Abandoned

see 45904

-- To view, visit https://review.coreboot.org/c/coreboot/+/45548 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I65aeeefeb1f144dad8826bfbe021d769df9a7135 Gerrit-Change-Number: 45548 Gerrit-PatchSet: 7 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Werner Zeh werner.zeh@siemens.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: abandon

1564

days inactive

1580

days old

coreboot-gerrit@coreboot.org

10 comments

3 participants

tags (0)

participants (3)

HAOUAS Elyes (Code Review)
Paul Menzel (Code Review)
Werner Zeh (Code Review)