Attention is currently required from: Paul Menzel, Christian Walter, Lean Sheng Tan.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68783 )
Change subject: mb/prodrive/atlas: Add IBECC Kconfig option ......................................................................
Patch Set 2: Code-Review+1
(7 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/68783/comment/d81e1d84_ac4ee475 PS1, Line 10: Code), which is currently needed for indurance testing
Please add a dot/period at the end of sentences.
Done
https://review.coreboot.org/c/coreboot/+/68783/comment/546d31cb_23ca997e PS1, Line 10: indurance testing
Is the test currently failing, or is the feature tested?
Seems to be resolved?
Commit Message:
https://review.coreboot.org/c/coreboot/+/68783/comment/029f57eb_e8110fcf PS2, Line 10: indurance *e*ndurance
https://review.coreboot.org/c/coreboot/+/68783/comment/dad8f444_4ced20fd PS2, Line 12: Test: start atlas mainboard with Linux. See in dmesg that IBECC (EDAC igen6) driver is loaded. Inject a fake error via debugfs and see in dmesg that Linux handles it. Please wrap at 72 characters
File src/mainboard/prodrive/atlas/Kconfig:
https://review.coreboot.org/c/coreboot/+/68783/comment/44db325a_a5a5c9cd PS2, Line 26: indurance *e*ndurance
https://review.coreboot.org/c/coreboot/+/68783/comment/3b6247c2_6aedb19c PS2, Line 27: not always required Why is it default enabled then?
File src/mainboard/prodrive/atlas/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/68783/comment/4251ee23_0e8e5243 PS2, Line 50: ? true : false This is redundant
-
Angel Pons (Code Review)