Attention is currently required from: Nick Vaccaro, Paul Menzel, Peter Ou, Ren Kuo, Subrata Banik.
David Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79059?usp=email )
Change subject: mb/google/brya/var/osiris: Update power limit values for RPL CPU
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79059/comment/27c24cb4_558c9b53 :
PS2, Line 11:
Maybe document how these compare to the default(?) values?
Done
Patchset:
PS2:
Usually we will have thermal report in the bug.
@Peter, would you please provide thermal report? Thanks.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79059?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia2540ecd1fc453701b9160c97d82ba50b88ee848
Gerrit-Change-Number: 79059
Gerrit-PatchSet: 3
Gerrit-Owner: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Peter Ou
peter.ou@quanta.corp-partner.google.com
Gerrit-Reviewer: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Peter Ou
peter.ou@quanta.corp-partner.google.com
Gerrit-Comment-Date: Wed, 15 Nov 2023 01:23:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai
ericllai@google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment