Attention is currently required from: Bora Guvendik, Furquan Shaikh, Selma Bensaid, Maulik V Vaghela, Tim Wawrzynczak, Paul Menzel, Meera Ravindranath, Subrata Banik, Angel Pons, Patrick Rudolph. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50996 )
Change subject: mb/adlrvp: Fix DDR5 Boot issue ......................................................................
Patch Set 15:
(7 comments)
File src/soc/intel/alderlake/meminit.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123629): https://review.coreboot.org/c/coreboot/+/50996/comment/42085bcc_0b319ce5 PS15, Line 222: static const int spd_array[] = { 0xA0, 0xA2, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0xA4, 0xA6, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123629): https://review.coreboot.org/c/coreboot/+/50996/comment/07bd092e_704958da PS15, Line 223: 0x0, 0x0, 0x0, 0x0, 0x0, 0x0 }; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123629): https://review.coreboot.org/c/coreboot/+/50996/comment/6eda3a5e_057f2646 PS15, Line 225: for (int i = 0; i < 16; i++) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123629): https://review.coreboot.org/c/coreboot/+/50996/comment/85009f6c_315047c2 PS15, Line 225: for (int i = 0; i < 16; i++) suspect code indent for conditional statements (7, 15)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123629): https://review.coreboot.org/c/coreboot/+/50996/comment/0997ea23_fe71f50d PS15, Line 226: mem_cfg->SpdAddressTable[i] = spd_array[i]; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123629): https://review.coreboot.org/c/coreboot/+/50996/comment/ba0c213d_768886ec PS15, Line 226: mem_cfg->SpdAddressTable[i] = spd_array[i]; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123629): https://review.coreboot.org/c/coreboot/+/50996/comment/3d244cc1_2034ac22 PS15, Line 266: mem_populate_channel_data(&soc_mem_cfg[mb_cfg->type], spd_info, half_populated, &data); line over 96 characters
-
build bot (Jenkins) (Code Review)